Switch version from function to string in azurevm#8346
Closed
sonalgaud12 wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8346 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 193 193
Lines 13769 13769
=====================================
Hits 11334 11334
Misses 2030 2030
Partials 405 405
🚀 New features to boost your workflow:
|
flc1125
reviewed
Jan 4, 2026
|
|
||
| if metadata.VMId != nil { | ||
| attributes = append(attributes, semconv.HostID(*metadata.VMId)) | ||
| attributes = append(attributes, semconv.HostIDKey.String(*metadata.VMId)) |
Member
There was a problem hiding this comment.
Can you explain why you want to adjust it this way?
For now, the functional style seems to be somewhat better.
Contributor
Author
There was a problem hiding this comment.
This follows issue #8272 to switch from helper functions to key-based strings for semantic conventions. I see your point about the functional style being cleaner. I just implemented as per my understanding of the issue, so in case we prefer the current implementation, I am happy to close the PR
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Version() func to const Version string in azurevm
Part of #8272