Skip to content

refactor(otelhttp): change Version() func to const Version string#8142

Merged
dmathieu merged 15 commits into
open-telemetry:mainfrom
dogedede:fix-const-version
Dec 9, 2025
Merged

refactor(otelhttp): change Version() func to const Version string#8142
dmathieu merged 15 commits into
open-telemetry:mainfrom
dogedede:fix-const-version

Conversation

@dogedede
Copy link
Copy Markdown
Contributor

@dogedede dogedede commented Nov 7, 2025

Fixes #8134
Changes the Version() definition in the otelhttp package from a function to a constant string for simplicity and consistency.

@dogedede dogedede requested review from a team and dmathieu as code owners November 7, 2025 12:37
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@dogedede
Copy link
Copy Markdown
Contributor Author

dogedede commented Nov 7, 2025

Apologies, I've updated the changelog.md.

Comment thread CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (2c083dd) to head (eb25c77).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8142     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        195     194      -1     
  Lines      13800   13798      -2     
=======================================
- Hits       11359   11357      -2     
  Misses      2033    2033             
  Partials     408     408             
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/common.go 100.0% <100.0%> (ø)
instrumentation/net/http/otelhttp/config.go 83.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dogedede dogedede requested a review from dmathieu November 10, 2025 04:07
Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/net/http/otelhttp/version.go Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Flc゛ <i@flc.io>
Comment thread CHANGELOG.md Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Comment thread CHANGELOG.md Outdated
@dogedede dogedede requested review from dmathieu and flc1125 November 22, 2025 07:22
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
@dmathieu dmathieu merged commit 713adee into open-telemetry:main Dec 9, 2025
28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otelhttp: func Version() string should just be const Version string

5 participants