Remove the deprecated WithRouteTag option in otelhttp#8268
Merged
dmathieu merged 8 commits intoopen-telemetry:mainfrom Dec 11, 2025
Merged
Remove the deprecated WithRouteTag option in otelhttp#8268dmathieu merged 8 commits intoopen-telemetry:mainfrom
WithRouteTag option in otelhttp#8268dmathieu merged 8 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
=======================================
- Coverage 82.3% 82.3% -0.1%
=======================================
Files 193 193
Lines 13778 13769 -9
=======================================
- Hits 11343 11334 -9
Misses 2030 2030
Partials 405 405
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated WithRouteTag function from the otelhttp instrumentation package. The function was previously deprecated because HTTP routes are now automatically added to spans, and for metrics, users should use WithMetricAttributesFn instead.
- Removed the
WithRouteTagfunction fromhandler.go - Removed the associated test
TestWithRouteTagfromhandler_test.goand cleaned up the unusedsemconvimport - Updated
CHANGELOG.mdto document the removal in the "Removed" section
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| instrumentation/net/http/otelhttp/handler.go | Removed the deprecated WithRouteTag function (22 lines) |
| instrumentation/net/http/otelhttp/handler_test.go | Removed the TestWithRouteTag test and cleaned up the unused semconv import |
| CHANGELOG.md | Added changelog entry documenting the removal, though contains an extraneous line about WithPublicEndpointFn |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix PR number. Remove copy paste error.
dashpole
reviewed
Dec 9, 2025
dashpole
approved these changes
Dec 9, 2025
dmathieu
approved these changes
Dec 9, 2025
pellared
approved these changes
Dec 9, 2025
1 task
This was referenced Feb 16, 2026
JoaoBraveCoding
added a commit
to JoaoBraveCoding/api
that referenced
this pull request
Feb 24, 2026
It was removed in open-telemetry/opentelemetry-go-contrib#8268 Approach was inspired by goadesign/goa#3897
philipgough
pushed a commit
to observatorium/api
that referenced
this pull request
Feb 26, 2026
* chore: update dependencies * fix race condition * chore: updated bingo tools * fix: move from the deprecated CFB to CTR * chore: updated some go expressions to recent standards * refactor: stop using deprecated WithRouteTag It was removed in open-telemetry/opentelemetry-go-contrib#8268 Approach was inspired by goadesign/goa#3897 * downgrade golangci-ling to 2.8.0 as it's the most recent version still on 1.24 * update github.com/efficientgo/e2e
Copilot AI
pushed a commit
to observatorium/api
that referenced
this pull request
Feb 26, 2026
* chore: update dependencies * fix race condition * chore: updated bingo tools * fix: move from the deprecated CFB to CTR * chore: updated some go expressions to recent standards * refactor: stop using deprecated WithRouteTag It was removed in open-telemetry/opentelemetry-go-contrib#8268 Approach was inspired by goadesign/goa#3897 * downgrade golangci-ling to 2.8.0 as it's the most recent version still on 1.24 * update github.com/efficientgo/e2e
philipgough
pushed a commit
to rhobs/api
that referenced
this pull request
Apr 10, 2026
* chore: update dependencies * fix race condition * chore: updated bingo tools * fix: move from the deprecated CFB to CTR * chore: updated some go expressions to recent standards * refactor: stop using deprecated WithRouteTag It was removed in open-telemetry/opentelemetry-go-contrib#8268 Approach was inspired by goadesign/goa#3897 * downgrade golangci-ling to 2.8.0 as it's the most recent version still on 1.24 * update github.com/efficientgo/e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.