fix(deps): update opentelemetry-go-contrib monorepo#1014
fix(deps): update opentelemetry-go-contrib monorepo#1014renovate-sh-app[bot] merged 2 commits intomainfrom
Conversation
|
open-telemetry/opentelemetry-go-contrib#8268 removed docker-otel-lgtm/examples/go/main.go Line 73 in 03c8865 I'm not familiar with what the changes to maintain the status quo would be though. |
seems we can just remove it (Deprecated: spans are automatically annotated with the route attribute.) |
9402dd5 to
90c74f0
Compare
will be fixed in #1025 |
90c74f0 to
60633e7
Compare
|
This PR should not be merged yet: upgrading otelhttp from v0.64.0 to v0.65.0 removes The claimed automatic route extraction from Upgrading now would cause a compile error (since we use We should wait for an otelhttp release that includes the fix from #7192. |
|
The tests fail and prevent merging anyway, so there's no harm in leaving auto-merge enabled until renovate updates this PR to a newer version with the fix. |
|
Good point. Once an otelhttp release ships that includes the fix from open-telemetry/opentelemetry-go-contrib#7192, the upgrade should be straightforward:
That's it — the |
let me look into that |
|
Update: the fix from #7192 is included in v0.65.0, but it only fixes the span name, not the Workaround (committed in 1dd6770): wrap individual route handlers instead of the whole mux: mux.Handle("/rolldice", otelhttp.NewHandler(http.HandlerFunc(rolldice), "/rolldice"))This way the ServeMux routes first, populates The |
| datasource | package | from | to | | ---------- | ------------------------------------------------------------- | ------- | ------- | | go | go.opentelemetry.io/contrib/bridges/otelslog | v0.14.0 | v0.15.0 | | go | go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp | v0.64.0 | v0.65.0 | | go | go.opentelemetry.io/contrib/instrumentation/runtime | v0.64.0 | v0.65.0 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
WithRouteTag was removed in otelhttp v0.65.0. The intended replacement (automatic http.route from r.Pattern) doesn't work when wrapping the whole ServeMux because RequestTraceAttrs runs before routing. Wrapping individual handlers instead lets ServeMux populate r.Pattern first, so otelhttp correctly sets the http.route span attribute.
1dd6770 to
cd34496
Compare

This PR contains the following updates:
v0.14.0→v0.15.0v0.64.0→v0.65.0v0.64.0→v0.65.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/bridges/otelslog)
v0.15.0Compare Source
[0.15.0] - 2020-12-11
Added
gcp.CloudRundetector for detecting resource from a Cloud Run instance. (#455)Raw changes made between v0.14.0 and v0.15.0
e7b70ebPrepare for v0.15.0 release (#486)54c6a6cAdd detector for Cloud Run service. (#455)79af2e9Bump google.golang.org/grpc from 1.33.2 to 1.34.0 in /instrumentation/google.golang.org/grpc/otelgrpc (#481)fd9db4aBump cloud.google.com/go from 0.72.0 to 0.73.0 in /detectors/gcp (#483)8f0fa29Bump google.golang.org/grpc from 1.33.2 to 1.34.0 in /instrumentation/google.golang.org/grpc/otelgrpc/example (#482)401ff52Bump google.golang.org/grpc from 1.33.2 to 1.34.0 in /propagators/opencensus/examples (#480)da8faf5Bump github.com/aws/aws-sdk-go from 1.35.35 to 1.36.2 in /detectors/aws (#479)b02fae7Add Amazon EKS Resource Detector (#465)d1534b8add opencensus propagation readme and example (#473)e1c598cAdd AWS X-Ray Propagator (#462)f9f5a21move opencensus binary propagation to contrib (#467)82eb6a3Bump github.com/google/go-cmp from 0.5.3 to 0.5.4 in /instrumentation/net/http/httptrace/otelhttptrace (#472)7ffe595Bump github.com/google/go-cmp from 0.5.3 to 0.5.4 in /propagators (#471)be1c230Bump github.com/google/go-cmp from 0.5.3 to 0.5.4 in /exporters/metric/cortex (#470)59c92e2Bump github.com/aws/aws-sdk-go from 1.35.33 to 1.35.35 in /detectors/aws (#469)9e9f21bBump github.com/golangci/golangci-lint from 1.32.2 to 1.33.0 in /tools (#468)645d23aAdd Amazon ECS Resource Detector (#466)d648427Bump github.com/aws/aws-sdk-go from 1.35.28 to 1.35.33 in /detectors/aws (#463)3be1f0dBump github.com/Shopify/sarama from 1.27.0 to 1.27.2 in /instrumentation/github.com/Shopify/sarama/otelsarama (#464)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.