Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service.name attribute #763

Merged
merged 4 commits into from
May 3, 2021
Merged

Remove service.name attribute #763

merged 4 commits into from
May 3, 2021

Commits on Apr 30, 2021

  1. Remove service.name attribute 

    `service.name` should correspond to the Resource of the entity
producing telemetry, not the remote service. If anything, the
attribute that should be used for a database service is `peer.service`.
    @evantorrie
    evantorrie committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    66b0f10 View commit details
    Browse the repository at this point in the history

  2. remember to make precommit first

    @evantorrie
    evantorrie committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    86ed6ca View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Add note to CHANGELOG regarding removal of service.name attribute

    @evantorrie
    evantorrie committed May 3, 2021
    Configuration menu
    Copy the full SHA
    6466b28 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into service-name

    @Aneurysm9
    Aneurysm9 authored May 3, 2021
    Configuration menu
    Copy the full SHA
    10984b8 View commit details
    Browse the repository at this point in the history