Remove service.name attribute #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`service.name` should correspond to the Resource of the entity producing telemetry, not the remote service. If anything, the attribute that should be used for a database service is `peer.service`.
evantorrie
requested review from
Aneurysm9,
dashpole,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
paivagustavo
approved these changes
Apr 30, 2021
Aneurysm9
approved these changes
Apr 30, 2021
jmacd
approved these changes
May 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service.nameshould correspond to the Resource of the entity producing telemetry, not the remote service.Relates to #454
This PR removes only the
service.namerelated aspects of the otelmongodb instrumentation. Other issues identified in #460 will be left to a separate PR.