Skip to content

deprecate SpanStartOption #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmathieu merged 8 commits into from
Jul 23, 2025
Merged

deprecate SpanStartOption #7601

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d32ae96
deprecate SpanStartOption
jan-xyz Jul 21, 2025
a42d691
improve deprecation notice
jan-xyz Jul 21, 2025
370c8af
add changelog entry
jan-xyz Jul 21, 2025
e45045e
fix wrong name of the function
jan-xyz Jul 21, 2025
63b8d40
improve changelog
jan-xyz Jul 22, 2025
b2730ba
improve deprecation note
jan-xyz Jul 22, 2025
f9e9871
Merge branch 'main' into deprecate_span_start_option
pellared Jul 22, 2025
ffad1f0
Merge branch 'main' into deprecate_span_start_option
dmathieu Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Add the `WithLoggerProviderOptions`, `WithMeterProviderOptions` and `WithTracerProviderOptions` options to `NewSDK` to allow passing custom options to providers in `go.opentelemetry.io/contrib/otelconf`. (#7552)
- Added V2 version of AWS EC2 detector `go.opentelemetry.io/contrib/detectors/aws/ec2/v2` due to deprecation of `github.com/aws/aws-sdk-go`. (#6961)

### Deprecated

- `WithSpanOptions` in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` is deprecated.
It is only used by the deprecated interceptor, and is unused in the new [NewClientHandler] implementation for StatsHandlers. (#7601)
Comment thread
jan-xyz marked this conversation as resolved.
Outdated

### Removed

- Remove support for the `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable as well as support for semantic conventions v1.20.0 in the modules below. (#7584)
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/google.golang.org/grpc/otelgrpc/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ func (o spanStartOption) apply(c *config) {

// WithSpanOptions configures an additional set of
// trace.SpanOptions, which are applied to each new span.
//
// Deprecated: It is only used by the deprecated interceptor, and is unused in the new [NewClientHandler] implementation for StatsHandlers.
Comment thread
jan-xyz marked this conversation as resolved.
Outdated
func WithSpanOptions(opts ...trace.SpanStartOption) Option {
return spanStartOption{opts}
}
Expand Down
Loading