Skip to content

deprecate SpanStartOption#7601

Merged
dmathieu merged 8 commits into
open-telemetry:mainfrom
jan-xyz:deprecate_span_start_option
Jul 23, 2025
Merged

deprecate SpanStartOption#7601
dmathieu merged 8 commits into
open-telemetry:mainfrom
jan-xyz:deprecate_span_start_option

Conversation

@jan-xyz
Copy link
Copy Markdown
Contributor

@jan-xyz jan-xyz commented Jul 21, 2025

Related: #7406

This only adds the deprecation, it is currently not used in the new stats handlers and should be removed when the interceptors are removed.

Comment thread instrumentation/google.golang.org/grpc/otelgrpc/config.go Outdated
Co-authored-by: David Ashpole <dashpole@google.com>
@dashpole
Copy link
Copy Markdown
Contributor

Seems like it would be helpful to have a changelog entry for this?

@jan-xyz
Copy link
Copy Markdown
Contributor Author

jan-xyz commented Jul 21, 2025

I only added the general notice from the function. I am not sure as there is no direct replacement for it. For now the only replacement that exists is the WithPublicEndpoint config, I believe.

Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/google.golang.org/grpc/otelgrpc/config.go Outdated
jan-xyz and others added 3 commits July 22, 2025 19:18
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dmathieu dmathieu merged commit 2e2c53f into open-telemetry:main Jul 23, 2025
28 checks passed
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 20, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants