Skip to content

runtime: add ns unit to deprecated runtime metrics #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pellared merged 4 commits into from
Jun 30, 2025
Merged

runtime: add ns unit to deprecated runtime metrics #7490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c4b328
fix: add ns units to deprecated runtime nanosecond metrics
Machyne Jun 18, 2025
db34d14
Update CHANGELOG.md
pellared Jun 30, 2025
6bb8572
Merge branch 'main' into mc/ns-unit
pellared Jun 30, 2025
4b6651b
Update CHANGELOG.md
pellared Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Added

- Add the unit `ns` to deprecated runtime metrics `process.runtime.go.gc.pause_total_ns` and `process.runtime.go.gc.pause_ns` in `go.opentelemetry.io/contrib/instrumentation/runtime`. (#7490)

<!-- Released section -->
<!-- Don't change this section unless doing release -->

Expand Down
4 changes: 2 additions & 2 deletions instrumentation/runtime/internal/deprecatedruntime/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,15 @@
// observation interval is too slow.
if pauseTotalNs, err = r.meter.Int64ObservableCounter(
"process.runtime.go.gc.pause_total_ns",
// TODO: nanoseconds units
metric.WithUnit("ns"),

Check warning on line 182 in instrumentation/runtime/internal/deprecatedruntime/runtime.go

View check run for this annotation

Codecov / codecov/patch

instrumentation/runtime/internal/deprecatedruntime/runtime.go#L182 

Added line #L182 was not covered by tests
metric.WithDescription("Cumulative nanoseconds in GC stop-the-world pauses since the program started"),
); err != nil {
return err
}

if gcPauseNs, err = r.meter.Int64Histogram(
"process.runtime.go.gc.pause_ns",
// TODO: nanoseconds units
metric.WithUnit("ns"),

Check warning on line 190 in instrumentation/runtime/internal/deprecatedruntime/runtime.go

View check run for this annotation

Codecov / codecov/patch

instrumentation/runtime/internal/deprecatedruntime/runtime.go#L190 

Added line #L190 was not covered by tests
metric.WithDescription("Amount of nanoseconds in GC stop-the-world pauses"),
); err != nil {
return err
Expand Down
Loading