Skip to content

runtime: add ns unit to deprecated runtime metrics#7490

Merged
pellared merged 4 commits intoopen-telemetry:mainfrom
Machyne:mc/ns-unit
Jun 30, 2025
Merged

runtime: add ns unit to deprecated runtime metrics#7490
pellared merged 4 commits intoopen-telemetry:mainfrom
Machyne:mc/ns-unit

Conversation

@Machyne
Copy link
Copy Markdown
Contributor

@Machyne Machyne commented Jun 18, 2025

Add missing ns units to the process.runtime.go.gc.pause_total_ns and process.runtime.go.gc.pause_ns metrics.

@Machyne Machyne requested review from a team, dashpole and dmathieu as code owners June 18, 2025 20:58
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@dmathieu dmathieu added the blocked: CLA Waiting on CLA to be signed before progress can be made label Jun 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.5%. Comparing base (ad44bed) to head (4b6651b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tion/runtime/internal/deprecatedruntime/runtime.go 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7490   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        198     198           
  Lines      17963   17963           
=====================================
  Hits       14647   14647           
  Misses      2917    2917           
  Partials     399     399           
Files with missing lines Coverage Δ
...tion/runtime/internal/deprecatedruntime/runtime.go 0.0% <0.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dashpole
Copy link
Copy Markdown
Contributor

Looks like this needs an entry in CHANGELOG.md and you need to sign the CLA.

@Machyne
Copy link
Copy Markdown
Contributor Author

Machyne commented Jun 25, 2025

Looks like this needs an entry in CHANGELOG.md and you need to sign the CLA.

Done and done! I thought I had the CLA sorted in advance, sorry about that. All good now though.

@dashpole dashpole removed the blocked: CLA Waiting on CLA to be signed before progress can be made label Jun 25, 2025
Comment thread CHANGELOG.md Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@pellared pellared changed the title fix: add ns units to deprecated runtime nanosecond metrics fix: add ns units to deprecated runtime metric Jun 30, 2025
@pellared pellared changed the title fix: add ns units to deprecated runtime metric fix: add ns unit to deprecated runtime metric Jun 30, 2025
@pellared pellared changed the title fix: add ns unit to deprecated runtime metric fix: add ns unit to deprecated runtime metrics Jun 30, 2025
@pellared pellared changed the title fix: add ns unit to deprecated runtime metrics runtime: add ns unit to deprecated runtime metrics Jun 30, 2025
@pellared pellared merged commit c94dd5b into open-telemetry:main Jun 30, 2025
28 of 29 checks passed
@MrAlias MrAlias added this to the v1.38.0 milestone Jul 17, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants