Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @wangzlei as a Code Owner #5736

Closed
wants to merge 4 commits into from
Closed

Add @wangzlei as a Code Owner #5736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a48f7a1
Revert "Deprecate the AWS XRAY sampler (#5648)"
MrAlias Jun 5, 2024
326cfca
Add @wangzlei as a Code Owner
MrAlias Jun 5, 2024
4c74cda
Merge branch 'main' into wangzlei-codeowner
MrAlias Jun 5, 2024
34038ea
Merge branch 'main' into wangzlei-codeowner
MrAlias Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5550]. (#5645)
- The `go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5552]. (#5646)
- The `go.opentelemetry.io/contrib/samplers/aws/xray` package is deprecated.
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5554]. (#5647)

[#5550]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5550
[#5551]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5551
[#5552]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5552
[#5554]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5554

### Changed

Expand Down
16 changes: 8 additions & 8 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ bridges/otelzap/ @open-te

config/ @open-telemetry/go-approvers @MadVikingGod @pellared @codeboten

detectors/aws/ec2 @open-telemetry/go-approvers @pyohannes @akats7
detectors/aws/ecs @open-telemetry/go-approvers @pyohannes @akats7
detectors/aws/eks @open-telemetry/go-approvers @pyohannes
detectors/aws/lambda @open-telemetry/go-approvers @akats7
detectors/aws/ec2 @open-telemetry/go-approvers @pyohannes @akats7 @wangzlei
detectors/aws/ecs @open-telemetry/go-approvers @pyohannes @akats7 @wangzlei
detectors/aws/eks @open-telemetry/go-approvers @pyohannes @wangzlei
detectors/aws/lambda @open-telemetry/go-approvers @akats7 @wangzlei
detectors/gcp/ @open-telemetry/go-approvers @dashpole

exporters/autoexport @open-telemetry/go-approvers @MikeGoldsmith @pellared

instrumentation/github.com/aws/aws-lambda-go/otellambda/ @open-telemetry/go-approvers @akats7
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/ @open-telemetry/go-approvers @akats7
instrumentation/github.com/aws/aws-lambda-go/otellambda/ @open-telemetry/go-approvers @akats7 @wangzlei
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/ @open-telemetry/go-approvers @akats7 @wangzlei
instrumentation/github.com/emicklei/go-restful/otelrestful/ @open-telemetry/go-approvers @dashpole
instrumentation/github.com/gin-gonic/gin/otelgin/ @open-telemetry/go-approvers @hanyuancheung
instrumentation/github.com/gorilla/mux/otelmux/ @open-telemetry/go-approvers @akats7
Expand All @@ -58,13 +58,13 @@ instrumentation/runtime/ @open-te
processors/baggage/baggagetrace @open-telemetry/go-approvers @codeboten @MikeGoldsmith

propagators/autoprop/ @open-telemetry/go-approvers @MrAlias
propagators/aws/ @open-telemetry/go-approvers @akats7
propagators/aws/ @open-telemetry/go-approvers @akats7 @wangzlei
propagators/b3/ @open-telemetry/go-approvers @pellared
propagators/jaeger/ @open-telemetry/go-approvers @yurishkuro
propagators/opencensus/ @open-telemetry/go-approvers @dashpole
propagators/ot/ @open-telemetry/go-approvers @pellared

samplers/aws/xray/ @open-telemetry/go-approvers
samplers/aws/xray/ @open-telemetry/go-approvers @wangzlei
samplers/jaegerremote/ @open-telemetry/go-approvers @yurishkuro
samplers/probability/consistent/ @open-telemetry/go-approvers @MadVikingGod

Expand Down
1 change: 0 additions & 1 deletion samplers/aws/xray/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Deprecated: xray has no Code Owner.
module go.opentelemetry.io/contrib/samplers/aws/xray

go 1.21
Expand Down
8 changes: 0 additions & 8 deletions samplers/aws/xray/remote_sampler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// Package xray provide an OpenTelemetry sampler for the AWS XRAY platform.
//
// Deprecated: xray has no Code Owner.
// After August 21, 2024, it may no longer be supported and may stop
// receiving new releases unless a new Code Owner is found. See
// [this issue] if you would like to become the Code Owner of this module.
//
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5554
package xray // import "go.opentelemetry.io/contrib/samplers/aws/xray"

import (
Expand Down