Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @wangzlei as a Code Owner #5736

Closed
wants to merge 4 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 5, 2024

cc @wangzlei

  • go.opentelemetry.io/otel/detectors/aws/ec2
  • go.opentelemetry.io/otel/detectors/aws/ecs
  • go.opentelemetry.io/otel/detectors/aws/eks
  • go.opentelemetry.io/otel/detectors/aws/lambda
  • go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda
  • go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws
  • go.opentelemetry.io/contrib/propagators/aws
  • go.opentelemetry.io/contrib/samplers/aws/xray

Closes #5542
Closes #5543
Closes #5544
Closes #5545
Closes #5546
Closes #5547
Closes #5553
Closes #5554

MrAlias added 2 commits June 5, 2024 07:56
- `go.opentelemetry.io/otel/detectors/aws/ec2`
- `go.opentelemetry.io/otel/detectors/aws/ecs`
- `go.opentelemetry.io/otel/detectors/aws/eks`
- `go.opentelemetry.io/otel/detectors/aws/lambda`
- `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda`
- `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`
- `go.opentelemetry.io/contrib/propagators/aws`
- `go.opentelemetry.io/contrib/samplers/aws/xray`
@MrAlias MrAlias requested a review from a team June 5, 2024 15:01
@MrAlias MrAlias added this to the v1.28.0 milestone Jun 5, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 5, 2024

@wangzlei please be sure to approve this after your review it to show you accept the responsibilities for being a Code Owner for these modules.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 18, 2024

@wangzlei please let me know if you are still able to be a code owner. We can close this if you are no longer able.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 20, 2024

Closing

@MrAlias MrAlias closed this Jun 20, 2024
@MrAlias MrAlias deleted the wangzlei-codeowner branch June 20, 2024 16:28
@MrAlias MrAlias removed this from the v1.28.0 milestone Jun 20, 2024
@wangzlei
Copy link
Contributor

wangzlei commented Oct 8, 2024

@MrAlias
AWS recently realizes the xray sampler has been removed from contrib due to missing code owner.
Could you help reopen this PR and add me as code owner? Thanks!

@wangzlei wangzlei mentioned this pull request Oct 8, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 9, 2024

@wangzlei I do not plan to reopen this. Your lack of responsiveness has removed any confidence I had that you would be able to effectively provide ownership for this.

Please do feel free to host a fork of the sampler if you or AWS would like to provide ownership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment