Revert "Remove libpf.Trace.Hash (#673)"#734
Merged
fabled merged 2 commits intoopen-telemetry:mainfrom Aug 26, 2025
Merged
Conversation
This reverts commit b4a95e6. The Hash was used as a key to not aggregate traces together. Add acomment about that. Fixes open-telemetry#732
florianl
approved these changes
Aug 26, 2025
christos68k
approved these changes
Aug 26, 2025
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 30, 2025
…#734) NOTE: Changes skipped via --skip option (had conflicts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b4a95e6.
The Hash was used as a key to not aggregate traces together. Add acomment about that.
Fixes #732