Remove libpf.Trace.Hash#673
Merged
fabled merged 2 commits intoopen-telemetry:mainfrom Aug 14, 2025
Merged
Conversation
This is legacy now. The Hash ID is not needed by any of the protocols. Only the APM integration needs a trace Hash as a correlation ID so keep the algorithm there.
fabled
force-pushed
the
tt-remove-libpftrace-hash
branch
from
66070bc to
b9e7d54
Compare
florianl
approved these changes
Aug 13, 2025
christos68k
approved these changes
Aug 13, 2025
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Aug 15, 2025
libpf.TraceHash got removed with open-telemetry/opentelemetry-ebpf-profiler#673 Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
fabled
added a commit
to fabled/opentelemetry-ebpf-profiler
that referenced
this pull request
Aug 26, 2025
This reverts commit b4a95e6. The Hash was used as a key to not aggregate traces together. Add acomment about that. Fixes open-telemetry#732
fabled
added a commit
that referenced
this pull request
Aug 26, 2025
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
NOTE: Changes skipped via --skip option (had conflicts)
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
NOTE: Changes skipped via --skip option (had conflicts)
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
NOTE: Changes skipped via --skip option (had conflicts)
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
NOTE: Changes skipped via --skip option (had conflicts)
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 30, 2025
…#734) NOTE: Changes skipped via --skip option (had conflicts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hash ID is not needed by any of the protocols in the tree. Only the APM integration needs a trace Hash as a correlation ID so keep the algorithm there.
Reduces memory usage and avoid calculating the hash as it is mostly unneeded.