interpreter: Support multiple interpreters for single ELF object#702
Merged
christos68k merged 7 commits intoopen-telemetry:mainfrom Aug 19, 2025
Merged
interpreter: Support multiple interpreters for single ELF object#702christos68k merged 7 commits intoopen-telemetry:mainfrom
christos68k merged 7 commits intoopen-telemetry:mainfrom
Conversation
gnurizen
force-pushed
the
multi-interpreters
branch
2 times, most recently
from
4a0f12a to
a7e9f0b
Compare
fabled
reviewed
Aug 18, 2025
Contributor
fabled
left a comment
fabled
left a comment
There was a problem hiding this comment.
Overall this looks good! Thanks! Few changes requested to MultiInstance.Symbolize implementation.
Comment on lines
+119
to
+130
| if err == nil && len(*frames) > initialLen { | ||
| // Successfully symbolized by this interpreter | ||
| return nil | ||
| } | ||
| // If symbolization didn't add any frames, reset and try next interpreter | ||
| if len(*frames) == initialLen { | ||
| continue | ||
| } | ||
| // If frames were added but there was an error, keep them and return | ||
| if err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if err == nil && len(*frames) > initialLen { | |
| // Successfully symbolized by this interpreter | |
| return nil | |
| } | |
| // If symbolization didn't add any frames, reset and try next interpreter | |
| if len(*frames) == initialLen { | |
| continue | |
| } | |
| // If frames were added but there was an error, keep them and return | |
| if err != nil { | |
| return err | |
| } | |
| if err != ErrMismatchInterpreterType { | |
| return err | |
| } |
The contract for Symbolizehas been to return interpreter.ErrMismatchInterpreterType if it did not recognize the frame. I think we can just return err here if it does not match this, because then this host.Frame belonged to this interpreter and something went wrong, or it successfully handled the frame.
| return err | ||
| } | ||
| } | ||
| return nil |
Contributor
There was a problem hiding this comment.
Suggested change
| return nil | |
| return ErrMismatchInterpreterType |
If none of the interpreters succeeds to handle the frame, this function should report this as an error.
- Add MultiData and MultiInstance types to handle multiple interpreters - Modify detectAndLoadInterpData to try all loaders instead of stopping at first match - Use errors.Join for proper compound error handling - Enables concurrent use of Go tracer and GoLabels on same binary Fixes issue where only the first matching interpreter loader would be used, preventing multiple interpreters from handling the same ELF object. Fixes open-telemetry#687
gnurizen
force-pushed
the
multi-interpreters
branch
from
a7e9f0b to
c4ed413
Compare
Contributor
Author
|
Thanks for the review @fabled, should be good to go! |
christos68k
reviewed
Aug 19, 2025
| allMetrics = append(allMetrics, metrics...) | ||
| } | ||
|
|
||
| return allMetrics, errors.Join(errs...) |
Member
There was a problem hiding this comment.
This breaks the existing caller assumption that no useful metrics are returned if error != nil, so we should probably also update the caller to process the metrics regardless of error.
christos68k
reviewed
Aug 19, 2025
| // This is a valid state - return nil, nil | ||
| return nil, nil | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
We're potentially swallowing/hiding an error here (if len(instances) > 0 && len(errs) > 0)), maybe we should log the latter case.
christos68k
approved these changes
Aug 19, 2025
| } | ||
|
|
||
| // Update metrics even if there was an error, because its possible ii is a multi-instance | ||
| // and some of the instances may have returned metrics. |
Member
There was a problem hiding this comment.
Suggested change
| // and some of the instances may have returned metrics. | |
| // and some of the underlying instances may have returned metrics. |
Member
|
Thanks, added some nits and simplifications, LGTM otherwise! |
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 8, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 8, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
gnurizen
added a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 18, 2025
…n-telemetry#702) Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where only the first matching interpreter loader would be used,
preventing multiple interpreters from handling the same ELF object.
Fixes #687