tpbase: codeql fixes#605
Merged
christos68k merged 3 commits intoopen-telemetry:mainfrom Jul 14, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
korniltsev
force-pushed
the
korniltsev/tpbase_codeql_fixes
branch
2 times, most recently
from
aad09d7 to
0daaac4
Compare
korniltsev
force-pushed
the
korniltsev/tpbase_codeql_fixes
branch
2 times, most recently
from
321741e to
1d0c31a
Compare
korniltsev
force-pushed
the
korniltsev/tpbase_codeql_fixes
branch
from
1d0c31a to
f531129
Compare
fabled
reviewed
Jul 14, 2025
| return 0, false | ||
| } | ||
| return val, true | ||
| if val > math.MaxUint16 { |
Contributor
There was a problem hiding this comment.
How about defining maxRegister = aa.V31 (that seems to be the largest valid register number) and use that here and in the other location?
Contributor
Author
There was a problem hiding this comment.
sure, applied.
to be fair it looks like Reg(%d) case should be just treated as an error and return false. but I decided to keep it, can remove later.
christos68k
approved these changes
Jul 14, 2025
This was referenced Aug 14, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 8, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 8, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the issues found in #602 as a separate change