tpbase: cgo-less amd routine decoders#602
Merged
fabled merged 4 commits intoopen-telemetry:mainfrom Jul 16, 2025
Merged
Conversation
korniltsev
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fabled
reviewed
Jul 14, 2025
fabled
reviewed
Jul 14, 2025
Contributor
fabled
left a comment
fabled
left a comment
There was a problem hiding this comment.
Thank you so much for working on this! Looks mostly good. Some comments. I realize the codeql seems to be just due to moved code, but perhaps you can fix those while doing this PR?
korniltsev
force-pushed
the
korniltsev/libc_cgoless
branch
from
3f8fbb2 to
db3d452
Compare
Contributor
Author
|
ok, I will try to handle codeql complains |
Merged
korniltsev
force-pushed
the
korniltsev/libc_cgoless
branch
2 times, most recently
from
7a4b096 to
ee2ca7d
Compare
christos68k
approved these changes
Jul 15, 2025
fabled
reviewed
Jul 16, 2025
Comment on lines
+43
to
+49
| offset := e.NewImmediateCapture("offset") | ||
| expected := e.Mem8( | ||
| e.Add( | ||
| e.MemWithSegment8(x86asm.GS, e.NewImmediateCapture("")), | ||
| offset, | ||
| ), | ||
| ) |
Contributor
There was a problem hiding this comment.
nit: Same as the other comment: move offset and expected outside the for block to reduce GC pressure by creating new variable instances for each step. Obviously the actual and Match call cannot move.
But is there any reason why expected definition could not be moved and reused for each step?
Contributor
Author
There was a problem hiding this comment.
ah yes, now I understand. will do
fabled
approved these changes
Jul 16, 2025
This was referenced Aug 14, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 10, 2025
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of #447
Use the new
amd.Interpreterinstead of cgo decoders in thetpbasepackage.