Conversation
#411 got created before Rust binary blobs were checked for differences but got merged after this check got in place. As #411 introduces some changes to the Rust code, the Rust binary blobs change and therefore the check for differences fails. Fix this by compiling the Rust binary blobs. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
christos68k
approved these changes
Apr 8, 2025
athre0z
approved these changes
Apr 8, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#411 got created before Rust binary blobs were checked for differences but got merged after this check got in place. As #411 introduces some changes to the Rust code, the Rust binary blobs change and therefore the check for differences fails. Fix this by compiling the Rust binary blobs.
This PR fixes the failing CI job on
main: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/actions/runs/14328632510