symblib: Add test case for go binaries symbconv#411
Merged
florianl merged 2 commits intoopen-telemetry:mainfrom Apr 8, 2025
Merged
symblib: Add test case for go binaries symbconv#411florianl merged 2 commits intoopen-telemetry:mainfrom
florianl merged 2 commits intoopen-telemetry:mainfrom
Conversation
Noticed Gosym(BadLineNumber) in the go-1.24.0 binary: WARN: bad line number of function (go:textfipsstart) WARN: bad line number of function (go:textfipsend)
florianl
reviewed
Mar 20, 2025
| continue 'outer; | ||
| } | ||
| Err(e) => { | ||
| return Err(e.into()); |
Member
There was a problem hiding this comment.
Just a thought and maybe we can add more context to the error.
Suggested change
| return Err(e.into()); | |
| return Err(Error::GoSymbol(e).context("Error in line mapping")); |
Contributor
Author
There was a problem hiding this comment.
Still fairly new to rust, but do think this would require me to use anyhow?
I have defined a new Error type GoSymbolBadLineMapping, that transports this context. Let me know you think.
christos68k
approved these changes
Mar 24, 2025
florianl
added a commit
that referenced
this pull request
Apr 8, 2025
#411 got created before Rust binary blobs were checked for differences but got merged after this check got in place. As #411 introduces some changes to the Rust code, the Rust binary blobs change and therefore the check for differences fails. Fix this by compiling the Rust binary blobs. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed Gosym(BadLineNumber) in the go-1.24.0 binary. So I have added handling in symbconv and a test.