Pass non-zero mapID into UpdateStackDeltaPages to fix cleanups#1274
Merged
fabled merged 1 commit intoopen-telemetry:mainfrom Mar 23, 2026
Merged
Pass non-zero mapID into UpdateStackDeltaPages to fix cleanups#1274fabled merged 1 commit intoopen-telemetry:mainfrom
fabled merged 1 commit intoopen-telemetry:mainfrom
Conversation
Previously it picked up zero from return values, which resulted in no deletes happening in practice, resulting in duplicate warnings and likely failure to profile for affected mappings.
Contributor
Author
|
Logging before the bug was fixed: I'm not exactly sure what's causing |
Contributor
Author
|
I think this was surfaced by #1144, but I'm not exactly sure on that point. It's good to fix it regardless. |
florianl
approved these changes
Mar 21, 2026
florianl
approved these changes
Mar 23, 2026
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it picked up zero from return values, which resulted in no deletes happening in practice, resulting in duplicate warnings and likely failure to profile for affected mappings.