Skip to content

fix(ruby): regex match 3.3.10#1256

Merged
christos68k merged 1 commit intoopen-telemetry:mainfrom
grafana:kk/ruby-regex-fix
Mar 17, 2026
Merged

fix(ruby): regex match 3.3.10#1256
christos68k merged 1 commit intoopen-telemetry:mainfrom
grafana:kk/ruby-regex-fix

Conversation

@korniltsev-grafanista
Copy link
Copy Markdown
Contributor

@korniltsev-grafanista korniltsev-grafanista commented Mar 17, 2026

No description provided.

@korniltsev-grafanista korniltsev-grafanista requested a review from a team as a code owner March 17, 2026 00:10
dalehamel
dalehamel reviewed Mar 17, 2026
View reviewed changes
Comment thread interpreter/ruby/ruby_test.go
{
// https://github.com/ruby/ruby/releases/tag/v3_3_10
name: "multi_digit_release",
input: "libruby.so.3.3.10",
Copy link
Copy Markdown
Contributor

@dalehamel dalehamel Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing this is how you discovered this was broken?

Copy link
Copy Markdown
Contributor Author

@korniltsev-grafanista korniltsev-grafanista Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I was testing your JIT change on a rubi built from the latest 3.3 tag which happened to be 3.3.10

dalehamel
dalehamel approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dalehamel dalehamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to rebase #1227 after this lands as it touches these lines, but it should resolve cleanly.

@dalehamel
Copy link
Copy Markdown
Contributor

dalehamel commented Mar 17, 2026

FYI i never got pinged as a code owner on this, i just noticed it because i watch the repo - not sure how that is supposed to work.

@christos68k christos68k merged commit 4c9ae93 into open-telemetry:main Mar 17, 2026
33 checks passed
@christos68k
Copy link
Copy Markdown
Member

christos68k commented Mar 17, 2026 •
edited
Loading

FYI i never got pinged as a code owner on this, i just noticed it because i watch the repo - not sure how that is supposed to work.

CC: @rogercoll

From here:

Run ./.github/workflows/scripts/add-codeowners-to-pr.sh
  ./.github/workflows/scripts/add-codeowners-to-pr.sh
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
    REPO: open-telemetry/opentelemetry-ebpf-profiler
    PR: 1256
##[debug]/usr/bin/bash -e /home/runner/work/_temp/8a00d00b-84de-4f57-a8dd-f1c8bccecc26.sh
This PR has not yet been reviewed, all code owners are eligible for a review request
No code owners found
##[debug]Finishing: Run add-codeowners-to-pr.sh

@rogercoll rogercoll mentioned this pull request Mar 18, 2026
Closed
@gnurizen gnurizen mentioned this pull request Mar 23, 2026
Closed
@korniltsev-grafanista korniltsev-grafanista mentioned this pull request Mar 25, 2026
Merged
This was referenced Apr 14, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florianl florianl florianl approved these changes

@christos68k christos68k christos68k approved these changes

+1 more reviewer

@dalehamel dalehamel dalehamel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@korniltsev-grafanista @dalehamel @christos68k @florianl