Skip to content

test: initialize metrics once in TestMain to prevent concurrent map access #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christos68k merged 2 commits into from
Mar 10, 2026
Merged

test: initialize metrics once in TestMain to prevent concurrent map access #1238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66add14
test: initialize metrics once in TestMain to prevent concurrent map a…
rogercoll Mar 10, 2026
a35d8d8
reference metrics package
rogercoll Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tracer/ebpf_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package tracer_test
import (
"context"
"math"
"os"
"runtime"
"slices"
"sync"
Expand All @@ -29,6 +30,13 @@ import (
"go.opentelemetry.io/otel/metric/noop"
)

func TestMain(m *testing.M) {
// Initialize metrics once to avoid concurrent map access between
// metrics.Start() and metrics.AddSlice() called from lingering periodiccaller goroutines.
metrics.Start(noop.Meter{})
os.Exit(m.Run())
}

type mockIntervals struct{}

func (mockIntervals) MonitorInterval() time.Duration { return 1 * time.Second }
Expand Down Expand Up @@ -91,8 +99,6 @@ func TestTracerErrorPropagation(t *testing.T) {
ctx, cancelFn := context.WithCancel(t.Context())
defer cancelFn()

metrics.Start(noop.Meter{})

tr, err := tracer.NewTracer(ctx, &tracer.Config{
Intervals: &mockIntervals{},
FilterErrorFrames: false,
Expand Down Expand Up @@ -135,8 +141,6 @@ func TestTracerMapMonitorsError(t *testing.T) {
ctx, cancelFn := context.WithCancel(t.Context())
defer cancelFn()

metrics.Start(noop.Meter{})

tr, err := tracer.NewTracer(ctx, &tracer.Config{
Intervals: &mockIntervals{},
FilterErrorFrames: false,
Expand All @@ -163,8 +167,6 @@ func TestTraceTransmissionAndParsing(t *testing.T) {
ctx, cancelFn := context.WithCancel(t.Context())
defer cancelFn()

metrics.Start(noop.Meter{})

enabledTracers, _ := tracertypes.Parse("")
enabledTracers.Enable(tracertypes.PythonTracer)
tr, err := tracer.NewTracer(ctx, &tracer.Config{
Expand Down