test: initialize metrics once in TestMain to prevent concurrent map access#1238
Merged
christos68k merged 2 commits intoopen-telemetry:mainfrom Mar 10, 2026
Merged
Conversation
…ccess Periodic caller goroutines from earlier tests may still be calling metrics.AddSlice after returning, racing with metrics. Start in subsequent tests.
1 task
Contributor
Author
|
We could use the mutex in |
florianl
approved these changes
Mar 10, 2026
christos68k
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periodic caller goroutines from earlier tests may still be calling metrics.AddSlice after cancelling the context, racing with metrics. Start in subsequent tests.
See failure example https://github.com/open-telemetry/opentelemetry-ebpf-profiler/actions/runs/22881720558/job/66385932626?pr=1237#step:7:285
Periodic caller non waited routine: https://github.com/rogercoll/opentelemetry-ebpf-profiler/blob/fix_integration_metrics/tracer/tracer.go#L1138