Skip to content

ci: allow conditional secrets for docker login #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlias merged 2 commits into from
Mar 3, 2026
Merged

ci: allow conditional secrets for docker login #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07cefe4
ci: allow conditional secrets for docker login
skl Mar 3, 2026
2cb4809
Revert "chore(deps): update confluentinc/cp-kafka docker tag to v8 (#…
skl Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/pull_request_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ on:
description: "Git ref (commit, branch, or tag) to check out"
required: false
type: string
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION:
description: "Docker Hub token for pulling images (optional)"
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -113,8 +117,19 @@ jobs:
ref: ${{ inputs.ref || github.sha }}
persist-credentials: false

- name: Check for Docker Hub token
id: check-docker-token
run: |
if [ -n "${DOCKER_TOKEN}" ]; then
Comment thread
MrAlias marked this conversation as resolved.
echo "has_token=true" >> "$GITHUB_OUTPUT"
else
echo "has_token=false" >> "$GITHUB_OUTPUT"
fi
env:
DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}

- name: Log in to Docker Hub
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
if: steps.check-docker-token.outputs.has_token == 'true'
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ vars.DOCKER_USERNAME }}
Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/pull_request_integration_tests_arm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ on:
description: "Git ref (commit, branch, or tag) to check out"
required: false
type: string
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION:
description: "Docker Hub token for pulling images (optional)"
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -119,8 +123,19 @@ jobs:
ref: ${{ inputs.ref || github.sha }}
persist-credentials: false

- name: Check for Docker Hub token
id: check-docker-token
run: |
if [ -n "${DOCKER_TOKEN}" ]; then
echo "has_token=true" >> "$GITHUB_OUTPUT"
else
echo "has_token=false" >> "$GITHUB_OUTPUT"
fi
env:
DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}

- name: Log in to Docker Hub
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
if: steps.check-docker-token.outputs.has_token == 'true'
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ vars.DOCKER_USERNAME }}
Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/pull_request_k8s_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ on:
description: "Git ref (commit, branch, or tag) to check out"
required: false
type: string
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION:
description: "Docker Hub token for pulling images (optional)"
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -111,8 +115,19 @@ jobs:
ref: ${{ inputs.ref || github.sha }}
persist-credentials: false

- name: Check for Docker Hub token
id: check-docker-token
run: |
if [ -n "${DOCKER_TOKEN}" ]; then
echo "has_token=true" >> "$GITHUB_OUTPUT"
else
echo "has_token=false" >> "$GITHUB_OUTPUT"
fi
env:
DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}

- name: Log in to Docker Hub
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
if: steps.check-docker-token.outputs.has_token == 'true'
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ vars.DOCKER_USERNAME }}
Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/pull_request_oats_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ on:
description: "Git ref (commit, branch, or tag) to check out"
required: false
type: string
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION:
description: "Docker Hub token for pulling images (optional)"
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -111,8 +115,19 @@ jobs:
ref: ${{ inputs.ref || github.sha }}
persist-credentials: false

- name: Check for Docker Hub token
id: check-docker-token
run: |
if [ -n "${DOCKER_TOKEN}" ]; then
echo "has_token=true" >> "$GITHUB_OUTPUT"
else
echo "has_token=false" >> "$GITHUB_OUTPUT"
fi
env:
DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}

- name: Log in to Docker Hub
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
if: steps.check-docker-token.outputs.has_token == 'true'
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ vars.DOCKER_USERNAME }}
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ jobs:
checks: write
pull-requests: write
actions: write
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}
with:
ref: ${{ inputs.tag || github.ref_name }}

Expand All @@ -126,6 +128,8 @@ jobs:
checks: write
pull-requests: write
actions: write
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}
with:
ref: ${{ inputs.tag || github.ref_name }}

Expand All @@ -138,6 +142,8 @@ jobs:
checks: write
pull-requests: write
actions: write
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}
with:
ref: ${{ inputs.tag || github.ref_name }}

Expand All @@ -150,6 +156,8 @@ jobs:
checks: write
pull-requests: write
actions: write
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}
with:
ref: ${{ inputs.tag || github.ref_name }}

Expand Down Expand Up @@ -189,6 +197,8 @@ jobs:
checks: write
pull-requests: write
actions: write
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}
with:
ref: ${{ inputs.tag || github.ref_name }}

Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/workflow_integration_tests_vm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ on:
description: "Git ref (commit, branch, or tag) to check out"
required: false
type: string
secrets:
DOCKER_TOKEN_EBPF_INSTRUMENTATION:
description: "Docker Hub token for pulling images (optional)"
required: false

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -121,8 +125,19 @@ jobs:
ref: ${{ inputs.ref || github.sha }}
persist-credentials: false

- name: Check for Docker Hub token
id: check-docker-token
run: |
if [ -n "${DOCKER_TOKEN}" ]; then
echo "has_token=true" >> "$GITHUB_OUTPUT"
else
echo "has_token=false" >> "$GITHUB_OUTPUT"
fi
env:
DOCKER_TOKEN: ${{ secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION }}

- name: Log in to Docker Hub
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
if: steps.check-docker-token.outputs.has_token == 'true'
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ vars.DOCKER_USERNAME }}
Expand Down
2 changes: 1 addition & 1 deletion internal/test/oats/kafka/docker-compose-obi-java-kafka.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ services:
- "2181:2181"

kafka:
image: confluentinc/cp-kafka:8.2.0@sha256:acbbf674f2ed40e5d0a8ca51beb0f00692c866fc22b5ce06f8cadbdc54cd4436
image: confluentinc/cp-kafka:7.9.5@sha256:c4c6b755551da17fff056b9c8b39700f99020083bd2d69a171ece4784f33e640
depends_on:
- zookeeper
environment:
Expand Down