ci: allow conditional secrets for docker login#1441
Merged
Conversation
MrAlias
reviewed
Mar 3, 2026
MrAlias
approved these changes
Mar 3, 2026
fix: zizmor secrets unconditionally inherited
dfc7c51 to
07cefe4
Compare
…pen-telemetry#1395)" This reverts commit 9dc67ce.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
- Coverage 44.89% 43.91% -0.98%
==========================================
Files 312 313 +1
Lines 28901 34213 +5312
==========================================
+ Hits 12974 15025 +2051
- Misses 15136 18210 +3074
- Partials 791 978 +187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out
if: secretsis not valid GitHub Actions workflow syntax on forks, so to make this docker login step optional we need to first use another step to actually check the secret.Then use output from above step as the condition. This should be more compatible.
To take advantage of this during the release process, the secret needs to be passed in from the parent workflow
usingand registered as an optional secret in thesecrets: inheritworkflow_calldefinition.