Skip to content

ci: allow conditional secrets for docker login#1441

Merged
MrAlias merged 2 commits into
open-telemetry:mainfrom
skl:skl/fix-github-actions-on-forks
Mar 3, 2026
Merged

ci: allow conditional secrets for docker login#1441
MrAlias merged 2 commits into
open-telemetry:mainfrom
skl:skl/fix-github-actions-on-forks

Conversation

@skl
Copy link
Copy Markdown
Member

@skl skl commented Mar 3, 2026

Turns out if: secrets is not valid GitHub Actions workflow syntax on forks, so to make this docker login step optional we need to first use another step to actually check the secret.

Then use output from above step as the condition. This should be more compatible.

To take advantage of this during the release process, the secret needs to be passed in from the parent workflow using secrets: inherit and registered as an optional secret in the workflow_call definition.

@skl skl requested a review from a team as a code owner March 3, 2026 21:59
Copy link
Copy Markdown
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

Comment thread .github/workflows/pull_request_integration_tests.yml
fix: zizmor secrets unconditionally inherited
@skl skl force-pushed the skl/fix-github-actions-on-forks branch from dfc7c51 to 07cefe4 Compare March 3, 2026 22:31
@MrAlias MrAlias merged commit 0970a01 into open-telemetry:main Mar 3, 2026
67 of 68 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.91%. Comparing base (0e24aab) to head (2cb4809).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   44.89%   43.91%   -0.98%     
==========================================
  Files         312      313       +1     
  Lines       28901    34213    +5312     
==========================================
+ Hits        12974    15025    +2051     
- Misses      15136    18210    +3074     
- Partials      791      978     +187     
Flag Coverage Δ
integration-test 21.55% <ø> (?)
integration-test-arm 0.00% <ø> (?)
integration-test-vm-x86_64-5.15.152 0.00% <ø> (?)
integration-test-vm-x86_64-6.10.6 0.00% <ø> (?)
k8s-integration-test 2.29% <ø> (?)
oats-test 0.00% <ø> (?)
unittests 44.91% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skl skl deleted the skl/fix-github-actions-on-forks branch March 3, 2026 23:53
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 5, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants