Allow loading multiple specs per tracer#1373
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 43.75% 43.77% +0.01%
==========================================
Files 310 310
Lines 33772 33816 +44
==========================================
+ Hits 14777 14803 +26
- Misses 18044 18058 +14
- Partials 951 955 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9dbef10 to
80647a3
Compare
80647a3 to
dc5131d
Compare
dc5131d to
20edcda
Compare
mmat11
approved these changes
Feb 27, 2026
grcevski
approved these changes
Feb 27, 2026
Contributor
grcevski
left a comment
There was a problem hiding this comment.
LGTM! I left some minor comments.
NimrodAvni78
pushed a commit
to coralogix/opentelemetry-ebpf-instrumentation
that referenced
this pull request
Mar 1, 2026
4 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively allows a tracer to be composed of multiple independent translation units - in other words, instead of doing:
A tracer can now
go:generateindividual.cfiles independently, each yielding its own.ofile, treated as independent translation units. Map sharing continue to work as usual due toOBI_PIN_INTERNAL.But why?
Glad you asked! Having different translation units allow us to have multiple/different definitions for a single function. For example, sock msg programs operate on a
struct sk_msgcontext, whilst sock skb programs operate onstruct __skb_bufcontexts. These have similar semantics, e.g.:dataanddata_endpointers)Being able to have multiple implementations allow writing common code. For instance:
The use case is exactly the one illustrated above: allowing programs featuring direct packet access to be generalised (WIP/different PR).
This PR changes
tpinjector/sock_iter.cto be a separate translation unit as an example.Checklist