Pgn/stat metrics#101

Closed

pinoOgni wants to merge 36 commits into

mainfrom

pgn/stat-metrics

pinoOgni commented Mar 4, 2026 •

edited

Loading

implement various TODOs
implement wakeup in ringbuf
add k8s env metric in devdocs
add unit tests in prometheus and otel exporters

gemini-code-assist Bot commented Mar 4, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

mmat11 reviewed

View reviewed changes

bpf/statsolly/k_tcp.c Outdated

bpf/statsolly/k_tcp.c Outdated

+              typedef struct tcp_rtt {
+                  u8 flags; // Must be first, we use it to tell what kind of event we have on the ring buffer
+                  u8 _pad[3];
+                  u32 srtt;

mmat11 Mar 5, 2026

can we change the name of this var to also contain the measure type used? eg. srtt_us or srtt_ms

pinoOgni Mar 5, 2026 •

edited

Loading

Author

right! ~~I think srtt_ms is good, I changed also the go struct field to SrttMs even if at the end is exported as seconds.. maybe we can decide the best option~~
Ok I think it's better to use srtt_us for the entire path and then at the end export it in second.

bpf/statsolly/k_tcp.c Outdated

bpf/statsolly/stats.c Outdated

internal/test/integration/docker-compose-go-stat-metrics.yml

pkg/internal/statsolly/transform/k8s/kubernetes.go


		func log() *slog.Logger { return slog.With("component", "k8s.MetadataDecorator") }

		func MetadataDecoratorProvider(

mmat11 Mar 5, 2026

I see now why this code is here, I think se should define the types first, and refactor all these enrichers to be generic, maybe in a different PR

pinoOgni Mar 5, 2026

Author

I was about to write this in the previous comment.. it seems too much to modify it in this PR but yes, this and other decorators could be common!

pkg/obi/stats_cfg.go Outdated

pkg/obi/stats_cfg.go

+              // TODO pinoOgni: right now it is a copy and paste of more or less netolly config
+              type StatsConfig struct {
+              	// AgentIP allows overriding the reported Agent IP address on each stat.
+              	AgentIP string `yaml:"agent_ip" env:"OTEL_EBPF_STATS_AGENT_IP" validate:"omitempty,ip" jsonschema:"type=string,format=ip"`

mmat11 Mar 5, 2026

should this be refactored to inherit from some struct in common with netolly?

pinoOgni Mar 5, 2026

Author

I was thinking something similar but in that case we will have issues with the env variables

pkg/obi/stats_cfg.go Outdated


		GeoIP stats.GeoIP `yaml:"geo_ip"`

		// TODO pinoOgni add more granular configuration

mmat11 Mar 5, 2026

leftover?

pinoOgni Mar 5, 2026 •

edited

Loading

Author

I would like to add a more granular configuration, not now but in future PRs so the user can select which metric calculate. Right now the idea is to "calculate everything and then the user can filter using attributes or the collector"
WDYT?
Update: I removed the comment, maybe I can do it in another PR

pkg/pipe/global/context.go

pinoOgni added 28 commits

March 5, 2026 17:03


          Introduction of application network tracer as part of appo11y

1967a4c

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Continue integration of appnetworktracer and create tcp rtt metric

7a7368c

exported with prom and otel

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add initial devdocs to add a new metric to appnetworktracer

cb6fd11

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update rtt metric with new labels (direction, server.port),

16e2ca6

add iters in the appnetworktracer

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Sort connection

3b84b00

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add is_tcp_socket_never_connected check

d2f57fb

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Fix minor stuff after first review

f973355

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Create itertcp in shared level to be used by multiple tracers.

ae8bef2

Pin listening_ports map.

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update appnetworktracer devdocs

f302093

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Code cleanup and review fixes

3b2c3ed

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add e2e integration test

5e55524

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update appnetworktracer devdocs

9f5b493

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add source and destination ports attributes

98b1955

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add TODO for application network metrics bucket definition

bffbcf6

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Rename enums and relocate app_network_events map

87f6720

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add tcpRtt metric in cleanupAllMetricsInstances method

8d53dcc

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update avail_data type in app_network_events_flags() function

1faabd9

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update metrics example in app-network-tracer doc

400f718

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Merge appnetworktracer with generictracer and use generictracer

5f9cb30

probes to calculate metric if the hook point is equal

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add integration tests for python app network metrics

e930e18

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          try to move appnettracer in netolly, rename app net metrics

d48063e

as stats metrics

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Revert netolly to original state

4a0777b

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Create statsolly with tcprtt sample metric

3783bf6

- Define statsolly
- Define statsolly pipeline
- Add sample tcp rtt ebpf probe
- Update configuration to use statsolly

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Add unit tests

3f48ada

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Remove appnetworktracer implementation

09a62f7

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update statsolly devdocs

ad12311

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Cleanup code and update some names

a13d04d

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Introduce statsolly e2e tests

9ec8d70

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>

pinoOgni added 7 commits

March 5, 2026 17:03


          Update config schema

39a5098

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Fix linter issues and update some comments

3c45f64

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Uniform names to stat metrics

ff254ac

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Continue to implement statsolly and clenaup pipeline

688fb59

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Remove interfacemanager and ifaces pkg from statsolly

6d8ece7

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update ringbuf pkg to be generic and used from both appolly and stats…

9c430a8

…olly

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>


          Update stat attributes with srcip and dstip as IPAddr and remove reqH…

bb8d207

…ostInfo

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>

pinoOgni force-pushed the pgn/stat-metrics branch from 35f3892 to bb8d207 Compare

March 5, 2026 16:03


          Apply review feedback

009314b

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>

pinoOgni force-pushed the pgn/stat-metrics branch from 96cd0bc to 009314b Compare

March 5, 2026 20:29

mmat11 commented Mar 7, 2026 •

edited

Loading

I think we should split the PR in multiple smaller ones, something like:

Initial statsolly types definitions
Decorators and common parts refactor into generic ones
Implementation with the previously added generic decorators and so on

I think it would be a bit too much to review all three in a single PR upstream

pinoOgni closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet