AWS cloud metadata decoration#1300
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
===========================================
+ Coverage 19.63% 43.57% +23.93%
===========================================
Files 239 307 +68
Lines 27971 32886 +4915
===========================================
+ Hits 5493 14331 +8838
+ Misses 21831 17636 -4195
- Partials 647 919 +272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nstrumentation into aws-metadata
…nstrumentation into aws-metadata
…nstrumentation into aws-metadata
grcevski
approved these changes
Feb 18, 2026
Contributor
grcevski
left a comment
grcevski
left a comment
There was a problem hiding this comment.
Very cool! I only had one small comment about the logging.
| resource, err := detector.Detect(ctx) | ||
| // none of the errors from the ec2 detect are retriable, so we just log them. | ||
| if err != nil { | ||
| log.Debug("failed to detect AWS EC2 metadata", "error", err) |
Contributor
There was a problem hiding this comment.
I think this is common for all cloud vendors, perhaps it shouldn't say AWS?
Contributor
Author
There was a problem hiding this comment.
Ohh good catch. I refactored this part to make it generic and I forgot to change some EC2 references. Thanks!
mariomac
force-pushed
the
aws-metadata
branch
from
75d1fc7 to
a3c93c7
Compare
Merged
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
The code also includes some methods for retrieving GCP and Azure metadata, but they will be properly tested in other PRs, to keep the focus of this PR.