Skip to content

update ConsoleActivityExporter to use Activity's enumerate methods #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2022
Merged

update ConsoleActivityExporter to use Activity's enumerate methods #4002

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51693be
update consoleactivityexporter to use enumerate methods
Dec 10, 2022
662379f
ref readonly
Dec 14, 2022
b1cf349
Merge branch 'main' into 3932_enumerate
CodeBlanch Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public override ExportResult Export(in Batch<Activity> batch)
if (activity.TagObjects.Any())
{
this.WriteLine("Activity.Tags:");
foreach (var tag in activity.TagObjects)
foreach (ref readonly var tag in activity.EnumerateTagObjects())
{
if (tag.Key == SpanAttributeConstants.StatusCodeKey)
{
Expand Down Expand Up @@ -96,10 +96,10 @@ public override ExportResult Export(in Batch<Activity> batch)
if (activity.Events.Any())
{
this.WriteLine("Activity.Events:");
foreach (var activityEvent in activity.Events)
foreach (ref readonly var activityEvent in activity.EnumerateEvents())
{
this.WriteLine($" {activityEvent.Name} [{activityEvent.Timestamp}]");
foreach (var attribute in activityEvent.Tags)
foreach (ref readonly var attribute in activityEvent.EnumerateTagObjects())
{
if (ConsoleTagTransformer.Instance.TryTransformTag(attribute, out var result))
{
Expand All @@ -112,7 +112,7 @@ public override ExportResult Export(in Batch<Activity> batch)
if (activity.Links.Any())
{
this.WriteLine("Activity.Links:");
foreach (var activityLink in activity.Links)
foreach (ref readonly var activityLink in activity.EnumerateLinks())
{
this.WriteLine($" {activityLink.Context.TraceId} {activityLink.Context.SpanId}");
foreach (ref readonly var attribute in activityLink.EnumerateTagObjects())
Expand Down