Skip to content

Conversation

@TimothyMothra
Copy link

Following up on this comment: #3932 (comment)

Changes

  • change ConsoleActivityExporter to use Enumerate methods in foreach

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team December 10, 2022 01:03
@TimothyMothra TimothyMothra changed the title update ConsoleActivityExporter to use enumerate methods update ConsoleActivityExporter to use Activity's enumerate methods Dec 10, 2022
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #4002 (51693be) into main (a44a58b) will decrease coverage by 0.11%.
The diff coverage is 25.00%.

❗ Current head 51693be differs from pull request most recent head b1cf349. Consider uploading reports for the commit b1cf349 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4002      +/-   ##
==========================================
- Coverage   85.54%   85.42%   -0.12%     
==========================================
  Files         289      289              
  Lines       11229    11233       +4     
==========================================
- Hits         9606     9596      -10     
- Misses       1623     1637      +14     
Impacted Files Coverage Δ
...emetry.Exporter.Console/ConsoleActivityExporter.cs 48.27% <25.00%> (ø)
...ing/Implementation/HostingExtensionsEventSource.cs 45.45% <0.00%> (-54.55%) ⬇️
...s.Hosting/Implementation/TelemetryHostedService.cs 73.33% <0.00%> (-26.67%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-15.00%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️
...lemetry/Trace/Builder/TracerProviderBuilderBase.cs 78.37% <0.00%> (+0.74%) ⬆️
...emetry/Metrics/Builder/MeterProviderBuilderBase.cs 94.54% <0.00%> (+1.56%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@CodeBlanch CodeBlanch merged commit 49d110a into open-telemetry:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants