MongoDB traces - update semantic conventions to v1.39.0 by aviralgarg05 · Pull Request #4791 · open-telemetry/opentelemetry-dotnet-instrumentation

aviralgarg05 · 2026-01-19T14:04:04Z

MongoDB - update semantic convention to v1.39.0 (#4786)

Why

OpenTelemetry Semantic Conventions have standardized database attribute names to ensure consistency across different language implementations. Specifically, the attribute db.system has been transitioned to db.system.name in the stable semantic conventions (finalized in v1.30.0 and kept in v1.39.0). This PR aligns the .NET AutoInstrumentation with these standards.

What

Code Change: Updated DbSystem constant from "db.system" to "db.system.name" in src/OpenTelemetry.AutoInstrumentation/Instrumentations/DatabaseAttributes.cs.
Test Alignment: Updated test/IntegrationTests/MongoDBTests.cs to expect the new db.system.name attribute in emitted spans.
Changelog: Added an entry to CHANGELOG.md under the "Unreleased" section.

Tests

Static Analysis: Verified that MongoDBInstrumentation.cs uses the DatabaseAttributes.Keys.DbSystem constant, ensuring the change propagates automatically.
Mock Collector Verification: Updated the integration test assertions to validate that the spans now correctly contain db.system.name.
Global Search: Performed a codebase-wide grep to ensure no other hardcoded strings of "db.system" were missed in the src or test directories.

Checklist

CHANGELOG.md is updated.
New features are covered by tests.

ysolomchenko · 2026-01-20T08:08:03Z

ActivitySource should also provide link to the schema
example PR how to do it: open-telemetry/opentelemetry-dotnet-contrib#3680

aviralgarg05 · 2026-01-20T10:37:18Z

ActivitySource should also provide link to the schema example PR how to do it: open-telemetry/opentelemetry-dotnet-contrib#3680

Resolved and implemented!

ysolomchenko

The following attributes should be set at span creation time rather than during execution.
https://github.com/open-telemetry/semantic-conventions/blob/v1.39.0/docs/db/mongodb.md?plain=1#L69

These attributes are not present on the formal span definition and having then in the examples is misleading - e.g. open-telemetry/opentelemetry-dotnet-instrumentation#4791 (comment)

Kielek

You have some issues with the tests.
What is more, I think it would be great to adjust expectations to cover new attributes.

lachmatt · 2026-01-28T17:09:05Z

SIG: @aviralgarg05 can you check the CI failures?

aviralgarg05 · 2026-01-28T17:20:00Z

SIG: @aviralgarg05 can you check the CI failures?

Yes I will fix them

Kielek

@aviralgarg05 thank you for the PR, I have pushed some direct feedback on your branch. I hope you are fine with these changes.

There is couple leftovers to be handled.

aviralgarg05 · 2026-02-02T11:15:30Z

I have fixed and resolved the comments.

ysolomchenko · 2026-02-02T11:34:42Z

I have fixed and resolved the comments.

It would be good to add tests for the error trace as well, since we have new logic here.
(You should update the test application for this)

aviralgarg05 · 2026-02-02T13:17:09Z

Added tests for MongoDB error traces:

New test: SubmitsTracesWithErrorDetails validates error handling
Test app updated with --trigger-error flag
ValidateErrorSpan checks error.type, exception events, and error status
RunWithError triggers MongoCommandException for testing

ysolomchenko · 2026-02-03T10:36:24Z

@aviralgarg05 can you check why the tests are failing and fix them?

Updates db.system to db.system.name in accordance with OpenTelemetry Semantic Conventions v1.39.0 (open-telemetry#4786).

ysolomchenko · 2026-02-04T09:21:17Z

I have tried multiple times to fix this one failing test. If you could go through it pls @ysolomchenko

This is not related to your changes. It’s just a flaky test that fails sometimes.

- Remove unrelated NoCodeTests.cs - Remove QueryWireProtocol instrumentation - Use DuckTyping for MongoCommandException.Code

QueryWireProtocol is valid for MongoDB versions earlier than 3.5

ysolomchenko · 2026-02-04T12:11:30Z

@aviralgarg05 I don’t have privileges to add direct commits, so I created them on my branch. Could you add them to this PR? It should fix the CI issues.
ysolomchenko@8cfe399
ysolomchenko@1ead8bf
ysolomchenko@7db5ccc
ysolomchenko@02263ad

Status codes are integers, not strings. Updated the test validation to check IntValue > 0 instead of checking StringValue.

ysolomchenko

LGTM

aviralgarg05 requested a review from a team as a code owner January 19, 2026 14:04

ysolomchenko reviewed Jan 20, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

ysolomchenko approved these changes Jan 20, 2026

View reviewed changes

ysolomchenko reviewed Jan 20, 2026

View reviewed changes

lmolkova reviewed Jan 22, 2026

View reviewed changes

Kielek changed the title ~~fix(mongodb): update semantic conventions to v1.39.0~~ MongoDB traces - update semantic conventions to v1.39.0 Jan 22, 2026

ysolomchenko reviewed Jan 22, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/DatabaseAttributes.cs Outdated

lmolkova mentioned this pull request Jan 23, 2026

[chore] MongoDB: remove network.* attributes from example open-telemetry/semantic-conventions#3322

Merged

Kielek reviewed Jan 23, 2026

View reviewed changes

lmolkova reviewed Jan 23, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs

lmolkova reviewed Jan 23, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs Outdated

Kielek requested a review from ysolomchenko January 29, 2026 10:55

Kielek reviewed Jan 29, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Kielek reviewed Jan 30, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs

Kielek reviewed Jan 30, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs Outdated

Kielek reviewed Jan 30, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs Outdated

Kielek requested a review from lmolkova January 30, 2026 09:22

ysolomchenko reviewed Feb 2, 2026

View reviewed changes

Comment thread test/IntegrationTests/MongoDBTests.cs

ysolomchenko reviewed Feb 2, 2026

View reviewed changes

Comment thread .github/instructions/codacy.instructions.md Outdated

ysolomchenko reviewed Feb 2, 2026

View reviewed changes

Comment thread test/IntegrationTests/MongoDBTests.cs Outdated

fix(mongodb): update semantic conventions to v1.39.0

ec79c81

Updates db.system to db.system.name in accordance with OpenTelemetry Semantic Conventions v1.39.0 (open-telemetry#4786).

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs Outdated

Address MongoDB semconv review feedback

670a7df

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/DatabaseAttributes.cs

Fix MongoDB review nits

a99519e

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread src/OpenTelemetry.AutoInstrumentation/Instrumentations/MongoDB/MongoDBInstrumentation.cs Outdated

Reorder MongoDB query checks

d64a9b6

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread test/IntegrationTests/NoCodeTests.cs

Comment thread ...erators/SourceGenerators.InstrumentationDefinitionsGenerator/InstrumentationDefinitions.g.cs

aviralgarg05 added 3 commits February 4, 2026 15:31

Update generated MongoDB definitions

de9de9e

Align NoCodeTests with main

4c610a6

Fix(MongoDB): address PR review comments

45e255e

- Remove unrelated NoCodeTests.cs - Remove QueryWireProtocol instrumentation - Use DuckTyping for MongoCommandException.Code

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread ...y.AutoInstrumentation/Instrumentations/MongoDB/Integrations/MongoClientIntegrationExecute.cs

Fix(MongoDB): restore QueryWireProtocol instrumentation

c718d78

QueryWireProtocol is valid for MongoDB versions earlier than 3.5

ysolomchenko and others added 5 commits February 4, 2026 17:45

fix InstrumentMethods

0585996

update tests/remove comments

0469126

revert NoCodeTests.cs

fc49612

update changelog

bcf951a

Merge upstream/main to resolve conflicts

f8e8a3c

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Fix(CHANGELOG): remove stray hyphen

6a8dc5b

ysolomchenko reviewed Feb 4, 2026

View reviewed changes

Comment thread test/IntegrationTests/MongoDBTests.cs Outdated

fix: use IntValue for db.response.status_code validation

911c184

Status codes are integers, not strings. Updated the test validation to check IntValue > 0 instead of checking StringValue.

ysolomchenko approved these changes Feb 4, 2026

View reviewed changes

nrcventura approved these changes Feb 4, 2026

View reviewed changes

zacharycmontoya approved these changes Feb 5, 2026

View reviewed changes

Merge branch 'main' into fix/mongodb-semconv-1.39.0

11257a9

Kielek enabled auto-merge (squash) February 16, 2026 09:52

Kielek merged commit 39e1008 into open-telemetry:main Feb 16, 2026
51 of 52 checks passed

Kielek mentioned this pull request Feb 17, 2026

MongoDB - update semantic convention to v1.39.0 #4786

Closed

Conversation

aviralgarg05 commented Jan 19, 2026

MongoDB - update semantic convention to v1.39.0 (#4786)

Why

What

Tests

Checklist

Uh oh!

Uh oh!

ysolomchenko commented Jan 20, 2026

Uh oh!

aviralgarg05 commented Jan 20, 2026

Uh oh!

ysolomchenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kielek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lachmatt commented Jan 28, 2026

Uh oh!

aviralgarg05 commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kielek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aviralgarg05 commented Feb 2, 2026

Uh oh!

Uh oh!

ysolomchenko commented Feb 2, 2026

Uh oh!

aviralgarg05 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ysolomchenko commented Feb 3, 2026

Uh oh!

ysolomchenko commented Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ysolomchenko commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ysolomchenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aviralgarg05 commented Feb 2, 2026 •

edited

Loading

ysolomchenko commented Feb 4, 2026 •

edited

Loading