Skip to content

[SqlClient] Instrumentation reports telemetry schema URL v1.33.0#3680

Merged
martincostello merged 4 commits intoopen-telemetry:mainfrom
Kielek:sqlclient-telemetry-url
Jan 13, 2026
Merged

[SqlClient] Instrumentation reports telemetry schema URL v1.33.0#3680
martincostello merged 4 commits intoopen-telemetry:mainfrom
Kielek:sqlclient-telemetry-url

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Jan 13, 2026

Follow up to open-telemetry/opentelemetry-dotnet#6164

I have a plan to make similar PRs for AspNet, AspNetCore, and Http as there are stable and have verified semantic convention.

Changes

[SqlClient] Instrumentation reports telemetry schema URL v1.33.0

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Jan 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.74%. Comparing base (52bd736) to head (4c86121).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
+ Coverage   71.72%   71.74%   +0.02%     
==========================================
  Files         445      445              
  Lines       17649    17663      +14     
==========================================
+ Hits        12658    12672      +14     
  Misses       4991     4991              
Flag Coverage Δ
unittests-Instrumentation.EntityFrameworkCore 80.80% <ø> (ø)
unittests-Instrumentation.SqlClient 87.46% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs 88.07% <100.00%> (ø)
...ent/Implementation/SqlEventSourceListener.netfx.cs 79.61% <100.00%> (ø)
...ion.SqlClient/Implementation/SqlTelemetryHelper.cs 95.52% <100.00%> (ø)
...lClient/SqlClientMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ation.SqlClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek marked this pull request as ready for review January 13, 2026 08:41
@Kielek Kielek requested a review from a team as a code owner January 13, 2026 08:41
@Kielek
Copy link
Copy Markdown
Member Author

Kielek commented Jan 13, 2026

AOT CI blocked by #3677

Comment thread src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md Outdated
Kielek and others added 2 commits January 13, 2026 10:49
Co-authored-by: Martin Costello <martin@martincostello.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants