Skip to content

[Instrumentation.AspNetCore] Fix missing grpc.method tag when empty tracestate header is present #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chinmaychahar wants to merge 1 commit into from
Closed

[Instrumentation.AspNetCore] Fix missing grpc.method tag when empty tracestate header is present #4503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void OnStartActivity(Activity activity, object? payload)
if (ctx.ActivityContext.IsValid()
&& !((ctx.ActivityContext.TraceId == activity.TraceId)
&& (ctx.ActivityContext.SpanId == activity.ParentSpanId)
&& (ctx.ActivityContext.TraceState == activity.TraceStateString)))
&& ((ctx.ActivityContext.TraceState ?? string.Empty) == (activity.TraceStateString ?? string.Empty))))
{
// Create a new activity with its parent set from the extracted context.
// This makes the new activity as a "sibling" of the activity created by
Expand Down
Loading