[Instrumentation.AspNetCore] Fix missing grpc.method tag when empty tracestate header is present#4503
Closed
chinmaychahar wants to merge 1 commit into
Closed
[Instrumentation.AspNetCore] Fix missing grpc.method tag when empty tracestate header is present#4503chinmaychahar wants to merge 1 commit into
chinmaychahar wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4503 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 438 438
Lines 18002 18002
=======================================
Hits 13657 13657
Misses 4345 4345
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3 tasks
Member
|
I think that it should be handled in this way open-telemetry/opentelemetry-dotnet#7407 |
Author
|
Thanks @Kielek! That's a cleaner fix. Since #7407 is already merged, should I close this PR? |
Member
|
@chinmaychahar, closing this PR makes sense to me. The issue will be after next OTel SDK release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4501
Changes
Normalize
nulland empty stringTraceStatecomparison inHttpInListener.OnStartActivityto prevent sibling activity creation when an emptytracestate:header is present.The .NET runtime's
W3CPropagatorsetsactivity.TraceStateString = nullfor an empty tracestate header, while OpenTelemetry'sCompositeTextMapPropagatorextractsTraceState = "". Both represent absent tracestate but==comparison treats them as different, triggering unnecessary sibling activity creation.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes