Skip to content

[OpAMP] Fix flakiness in tests #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OpAMP] Fix flakiness in tests #4169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aa78e8
Initial plan
Copilot Apr 21, 2026
9301891
fix(opamp): tolerate WebSocketException/OperationCanceledException in…
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions test/OpenTelemetry.OpAmp.Client.Tests/WsTransportTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,14 @@ public async Task WsTransport_DropsOversizedResponseWithoutDispatchingFrame()

using var wsTransport = CreateTransport(opAmpServer.Endpoint, frameProcessor);
await wsTransport.StartAsync(CancellationToken.None);
await wsTransport.SendAsync(FrameGenerator.GenerateMockAgentFrame().Frame, CancellationToken.None);

// SendAsync can race with the receiver aborting the socket after detecting the oversized response.
// On .NET Framework this may surface as a WebSocketException (Aborted state) or OperationCanceledException.
var sendException = await Record.ExceptionAsync(
() => wsTransport.SendAsync(FrameGenerator.GenerateMockAgentFrame().Frame, CancellationToken.None));
Assert.True(
sendException is null || sendException is WebSocketException || sendException is OperationCanceledException,
$"Unexpected exception from SendAsync: {sendException}");

Assert.True(opAmpServer.TryGetClientCloseStatus(TimeSpan.FromSeconds(5), out var closeStatus));
Assert.Equal(WebSocketCloseStatus.MessageTooBig, closeStatus);
Expand Down Expand Up @@ -313,7 +320,14 @@ public async Task WsTransport_LogsOversizedResponseWarning()

using var wsTransport = CreateTransport(opAmpServer.Endpoint, new FrameProcessor());
await wsTransport.StartAsync(CancellationToken.None);
await wsTransport.SendAsync(FrameGenerator.GenerateMockAgentFrame().Frame, CancellationToken.None);

// SendAsync can race with the receiver aborting the socket after detecting the oversized response.
// On .NET Framework this may surface as a WebSocketException (Aborted state) or OperationCanceledException.
var sendException = await Record.ExceptionAsync(
() => wsTransport.SendAsync(FrameGenerator.GenerateMockAgentFrame().Frame, CancellationToken.None));
Assert.True(
sendException is null || sendException is WebSocketException || sendException is OperationCanceledException,
$"Unexpected exception from SendAsync: {sendException}");

Assert.True(opAmpServer.TryGetClientCloseStatus(TimeSpan.FromSeconds(5), out var closeStatus));
Assert.Equal(WebSocketCloseStatus.MessageTooBig, closeStatus);
Expand Down
Loading