Skip to content

[SqlClient.Tests] Avoid setting OTEL_SEMCONV_STABILITY_OPT_IN#3682

Merged
Kielek merged 2 commits intoopen-telemetry:mainfrom
Kielek:sqlclient-test-cleanup
Jan 13, 2026
Merged

[SqlClient.Tests] Avoid setting OTEL_SEMCONV_STABILITY_OPT_IN#3682
Kielek merged 2 commits intoopen-telemetry:mainfrom
Kielek:sqlclient-test-cleanup

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Jan 13, 2026

Follow op: #3592

Changes

[SqlClient.Tests] Avoid setting OTEL_SEMCONV_STABILITY_OPT_IN

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek marked this pull request as ready for review January 13, 2026 10:21
@Kielek Kielek requested a review from a team as a code owner January 13, 2026 10:21
@Kielek Kielek enabled auto-merge January 13, 2026 10:21
@github-actions github-actions Bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Jan 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (52bd736) to head (05ba731).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3682   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         445      445           
  Lines       17649    17649           
=======================================
  Hits        12658    12658           
  Misses       4991     4991           
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek added this pull request to the merge queue Jan 13, 2026
Merged via the queue into open-telemetry:main with commit 6a0ef7d Jan 13, 2026
72 checks passed
@Kielek Kielek deleted the sqlclient-test-cleanup branch January 13, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants