Skip to content

[SqlClient] Remove support for old DB conventions#3592

Merged
alanwest merged 2 commits intoopen-telemetry:mainfrom
alanwest:alanwest/prepare-sql-client-for-rc
Dec 16, 2025
Merged

[SqlClient] Remove support for old DB conventions#3592
alanwest merged 2 commits intoopen-telemetry:mainfrom
alanwest:alanwest/prepare-sql-client-for-rc

Conversation

@alanwest
Copy link
Copy Markdown
Member

@alanwest alanwest commented Dec 9, 2025

This PR prepares the SqlClient instrumentation to release a release candidate.

It removes support for the old DB conventions. Only the stable conventions will be emitted.

@github-actions github-actions Bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Dec 9, 2025
@alanwest alanwest force-pushed the alanwest/prepare-sql-client-for-rc branch 5 times, most recently from b3a3fe4 to a5c1608 Compare December 9, 2025 00:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.19%. Comparing base (48d18f6) to head (dc480c1).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...qlClient/Implementation/SqlActivitySourceHelper.cs 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   71.22%   71.19%   -0.03%     
==========================================
  Files         442      442              
  Lines       17516    17489      -27     
==========================================
- Hits        12475    12451      -24     
+ Misses       5041     5038       -3     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.19% <95.45%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs 88.23% <100.00%> (-0.08%) ⬇️
...ent/Implementation/SqlEventSourceListener.netfx.cs 79.80% <100.00%> (-1.28%) ⬇️
....SqlClient/SqlClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...qlClient/Implementation/SqlActivitySourceHelper.cs 94.54% <90.00%> (+3.24%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alanwest alanwest force-pushed the alanwest/prepare-sql-client-for-rc branch 2 times, most recently from baa8a11 to e87dbc0 Compare December 9, 2025 00:38
@alanwest alanwest force-pushed the alanwest/prepare-sql-client-for-rc branch from e87dbc0 to b4e5494 Compare December 9, 2025 00:44
@alanwest alanwest marked this pull request as ready for review December 12, 2025 22:29
@alanwest alanwest requested a review from a team as a code owner December 12, 2025 22:29
@Kielek Kielek changed the title Remove support for old DB conventions [SqlClient] Remove support for old DB conventions Dec 16, 2025
Copy link
Copy Markdown
Member

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with merging iit now, but before release, it will be great to solve #3574 fisrt.

@alanwest
Copy link
Copy Markdown
Member Author

I am fine with merging iit now, but before release, it will be great to solve #3574 fisrt.

Agreed. Merging now. If there's some progress on #3574 in the coming week or so maybe we can get an RC out near the end of the year.

@alanwest alanwest added this pull request to the merge queue Dec 16, 2025
Merged via the queue into open-telemetry:main with commit 9f71a33 Dec 16, 2025
72 checks passed
@alanwest alanwest deleted the alanwest/prepare-sql-client-for-rc branch December 16, 2025 19:59
martincostello added a commit to martincostello/opentelemetry-dotnet-contrib that referenced this pull request Dec 17, 2025
Update expected span name after changes in open-telemetry#3592.
@stevejgordon
Copy link
Copy Markdown
Contributor

@alanwest and @Kielek - I've solved all but one edge case in the SQL processor. Working on that this morning, with a hope to get a PR in today/tomorrow.

@stevejgordon
Copy link
Copy Markdown
Contributor

#3627 fixes the handling of escaped identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants