Skip to content

[OpAMP] Clean up internal directory and namespace#3612

Merged
Kielek merged 2 commits intoopen-telemetry:mainfrom
stevejgordon:opamp-cleanup-internal
Dec 12, 2025
Merged

[OpAMP] Clean up internal directory and namespace#3612
Kielek merged 2 commits intoopen-telemetry:mainfrom
stevejgordon:opamp-cleanup-internal

Conversation

@stevejgordon
Copy link
Copy Markdown
Contributor

Fixes #3609

Changes

  • Move all public types out of the "Internal" directory and update namespaces accordingly.
  • Move internal messages into a specific "Messages" directory and update namespace accordingly.
  • Update using directives for all dependant types.
  • Update unshipped public API

One other

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

- Move all public types out of the "Internal" directory and update namespaces accordingly.
- Move internal messages into a specific "Messages" directory and update namespace accordingly.
- Update using directives for all dependant types.
- Update unshipped public API
@stevejgordon stevejgordon requested a review from a team as a code owner December 12, 2025 10:59
@github-actions github-actions Bot requested a review from RassK December 12, 2025 10:59
@github-actions github-actions Bot added the comp:opamp.client Things related to OpenTelemetry.OpAmp.Client label Dec 12, 2025
@Kielek Kielek changed the title Clean up internal directory and namespace [OpAMP] Clean up internal directory and namespace Dec 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.43%. Comparing base (57c7f48) to head (5349ca1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3612   +/-   ##
=======================================
  Coverage   71.43%   71.43%           
=======================================
  Files         442      442           
  Lines       17522    17522           
=======================================
  Hits        12517    12517           
  Misses       5005     5005           
Flag Coverage Δ
unittests-OpAmp.Client 78.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nTelemetry.OpAmp.Client/Internal/FrameProcessor.cs 83.33% <ø> (ø)
...nt/Internal/Messages/AgentIdentificationMessage.cs 0.00% <ø> (ø)
...mp.Client/Internal/Messages/CapabilitiesMessage.cs 0.00% <ø> (ø)
...y.OpAmp.Client/Internal/Messages/CommandMessage.cs 0.00% <ø> (ø)
...ent/Internal/Messages/ConnectionSettingsMessage.cs 0.00% <ø> (ø)
...ent/Internal/Messages/CustomCapabilitiesMessage.cs 0.00% <ø> (ø)
...p.Client/Internal/Messages/CustomMessageMessage.cs 100.00% <ø> (ø)
...p.Client/Internal/Messages/ErrorResponseMessage.cs 0.00% <ø> (ø)
...try.OpAmp.Client/Internal/Messages/FlagsMessage.cs 0.00% <ø> (ø)
...ient/Internal/Messages/PackagesAvailableMessage.cs 0.00% <ø> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/OpenTelemetry.OpAmp.Client/CHANGELOG.md Outdated
Co-authored-by: Martin Costello <martin@martincostello.com>
@Kielek Kielek added this pull request to the merge queue Dec 12, 2025
Merged via the queue into open-telemetry:main with commit f441e6e Dec 12, 2025
67 checks passed
@stevejgordon stevejgordon deleted the opamp-cleanup-internal branch December 12, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:opamp.client Things related to OpenTelemetry.OpAmp.Client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OpAMP] Cleanup OpAMP folders and namespaces

4 participants