Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate resource attributes into process tags in Jaeger #897

Merged

Conversation

ThomsonTan
Copy link
Contributor

Fixes #767

Changes

Current only service.name is set to Jaeger span, this PR populates all other resources attributes into tags in Jaeger process object.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 8, 2021 18:57
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #897 (cf3bdd0) into main (016bb85) will increase coverage by 0.03%.
The diff coverage is 93.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   95.38%   95.40%   +0.03%     
==========================================
  Files         158      158              
  Lines        6705     6717      +12     
==========================================
+ Hits         6395     6408      +13     
+ Misses        310      309       -1     
Impacted Files Coverage Δ
...pi/include/opentelemetry/context/runtime_context.h 97.47% <66.67%> (ø)
sdk/test/trace/tracer_test.cc 99.48% <100.00%> (+0.02%) ⬆️
...include/opentelemetry/sdk/common/circular_buffer.h 100.00% <0.00%> (+2.09%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the formatting is fixed.

exporters/jaeger/src/recordable.cc Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lalitb lalitb merged commit 2209343 into open-telemetry:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Exporter : Mapping OTel Resource into Jaeger Process
3 participants