Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger Exporter : Mapping OTel Resource into Jaeger Process #767

Closed
lalitb opened this issue May 19, 2021 · 4 comments · Fixed by #897
Closed

Jaeger Exporter : Mapping OTel Resource into Jaeger Process #767

lalitb opened this issue May 19, 2021 · 4 comments · Fixed by #897
Assignees
Labels
area:exporter bug Something isn't working release:required-for-ga To be resolved before GA release
Milestone

Comments

@lalitb
Copy link
Member

lalitb commented May 19, 2021

Current Jaeger Thrift exporter implementation maps service_name from resource attributes into Jaeger process. The rest of the resource attributes also need to be mapped to the Jaeger Process as mentioned in specs:
https://github.com/open-telemetry/opentelemetry-specification/blob/v1.0.0/specification/trace/sdk_exporters/jaeger.md#resource

This is how it is handled by otel-go implementation: https://github.com/open-telemetry/opentelemetry-go/blob/d3b1280863f421bba9656543296b71c133f1ba13/exporters/trace/jaeger/jaeger.go#L346

@lalitb lalitb added bug Something isn't working area:exporter release:required-for-ga To be resolved before GA release labels May 19, 2021
@lalitb lalitb added this to the 1.0.0 GA milestone May 19, 2021
@anshulkumar19
Copy link
Contributor

@lalitb Can you assign this to me?

@lalitb
Copy link
Member Author

lalitb commented Jul 6, 2021

@anshulkumar19 - Do you want me to pick this up, as we need to fix this for GA.

@anshulkumar19
Copy link
Contributor

@anshulkumar19 - Do you want me to pick this up, as we need to fix this for GA.

Sorry @lalitb for coming late on this, please pick this up as needed for GA and I am little bit occupied with other things.

@ThomsonTan
Copy link
Contributor

@anshulkumar19 no problem. I'll take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:exporter bug Something isn't working release:required-for-ga To be resolved before GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants