Skip to content

[SDK] Swap Tracer/Meter/LoggerConfig disabled for enabled #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcalff merged 5 commits into from
Mar 19, 2026
Merged

[SDK] Swap Tracer/Meter/LoggerConfig disabled for enabled #3942

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90b0da9
Swap Tracer/Meter/LoggerConfig disabled for enabled to avoid double n…
AyushMukkanwar Mar 18, 2026
d757014
Merge branch 'main' into fix-config-double-negative
lalitb Mar 18, 2026
325555b
Update CHANGELOG.md for TracerConfig, MeterConfig, and LoggerConfig b…
AyushMukkanwar Mar 18, 2026
1199afa
Apply suggestions from code review
marcalff Mar 18, 2026
f8e1d91
Merge branch 'main' into fix-config-double-negative
marcalff Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/include/opentelemetry/sdk/logs/logger_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ class OPENTELEMETRY_EXPORT LoggerConfig
static LoggerConfig Default();

private:
explicit LoggerConfig(const bool disabled = false) : disabled_(disabled) {}
explicit LoggerConfig(const bool enabled = true) : enabled_(enabled) {}

bool disabled_;
bool enabled_;
};
} // namespace logs
} // namespace sdk
Expand Down
4 changes: 2 additions & 2 deletions sdk/include/opentelemetry/sdk/metrics/meter_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ class OPENTELEMETRY_EXPORT MeterConfig
static MeterConfig Default();

private:
explicit MeterConfig(const bool disabled = false) : disabled_(disabled) {}
bool disabled_;
explicit MeterConfig(const bool enabled = true) : enabled_(enabled) {}
bool enabled_;
};
} // namespace metrics
} // namespace sdk
Expand Down
4 changes: 2 additions & 2 deletions sdk/include/opentelemetry/sdk/trace/tracer_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ class OPENTELEMETRY_EXPORT TracerConfig
static TracerConfig Default();

private:
explicit TracerConfig(const bool disabled = false) : disabled_(disabled) {}
bool disabled_;
explicit TracerConfig(const bool enabled = true) : enabled_(enabled) {}
bool enabled_;
};
} // namespace trace
} // namespace sdk
Expand Down
6 changes: 3 additions & 3 deletions sdk/src/logs/logger_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ namespace logs

OPENTELEMETRY_EXPORT bool LoggerConfig::operator==(const LoggerConfig &other) const noexcept
{
return disabled_ == other.disabled_;
return enabled_ == other.enabled_;
}

OPENTELEMETRY_EXPORT bool LoggerConfig::IsEnabled() const noexcept
{
return !disabled_;
return enabled_;
}

OPENTELEMETRY_EXPORT LoggerConfig LoggerConfig::Enabled()
Expand All @@ -26,7 +26,7 @@ OPENTELEMETRY_EXPORT LoggerConfig LoggerConfig::Enabled()

OPENTELEMETRY_EXPORT LoggerConfig LoggerConfig::Disabled()
{
static const auto kDisabledConfig = LoggerConfig(true);
static const auto kDisabledConfig = LoggerConfig(false);
return kDisabledConfig;
}

Expand Down
6 changes: 3 additions & 3 deletions sdk/src/metrics/meter_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ namespace metrics

OPENTELEMETRY_EXPORT bool MeterConfig::operator==(const MeterConfig &other) const noexcept
{
return disabled_ == other.disabled_;
return enabled_ == other.enabled_;
}

OPENTELEMETRY_EXPORT bool MeterConfig::IsEnabled() const noexcept
{
return !disabled_;
return enabled_;
}

OPENTELEMETRY_EXPORT MeterConfig MeterConfig::Disabled()
{
static const auto kDisabledConfig = MeterConfig(true);
static const auto kDisabledConfig = MeterConfig(false);
return kDisabledConfig;
}

Expand Down
6 changes: 3 additions & 3 deletions sdk/src/trace/tracer_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace trace

OPENTELEMETRY_EXPORT TracerConfig TracerConfig::Disabled()
{
static const auto kDisabledConfig = TracerConfig(true);
static const auto kDisabledConfig = TracerConfig(false);
return kDisabledConfig;
}

Expand All @@ -28,12 +28,12 @@ OPENTELEMETRY_EXPORT TracerConfig TracerConfig::Default()

OPENTELEMETRY_EXPORT bool TracerConfig::IsEnabled() const noexcept
{
return !disabled_;
return enabled_;
}

OPENTELEMETRY_EXPORT bool TracerConfig::operator==(const TracerConfig &other) const noexcept
{
return disabled_ == other.disabled_;
return enabled_ == other.enabled_;
}

} // namespace trace
Expand Down
Loading