[SDK] Swap Tracer/Meter/LoggerConfig disabled for enabled#3942
[SDK] Swap Tracer/Meter/LoggerConfig disabled for enabled#3942marcalff merged 5 commits intoopen-telemetry:mainfrom
Conversation
|
|
|
Please remove the links to private files in the change set comments, like cci:2://file:///home/ayush_mukkanwar/Dev/OSS/opentelemetry-cpp/sdk/test/trace/tracer_config_test.cc:76:0-78:2 No need to link to a file name and line number, just |
sorry about that, just signed the cla. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3942 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 226 226
Lines 7229 7229
==========================================
- Hits 6510 6509 -1
- Misses 719 720 +1
🚀 New features to boost your workflow:
|
marcalff
left a comment
There was a problem hiding this comment.
Looks good overall.
Please add a CHANGELOG entry, and a new entry in the important notes section:
In TracerConfig(bool) and friends, the meaning of the bool parameter has changed, user code needs to be adjusted.
(to reword of course)
…ool parameter swap
|
CI break is: |
marcalff
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix.
Will merge after formatting fixes in CHANGELOG.md
Co-authored-by: Marc Alff <marc.alff@free.fr>
Fixes #3867
Changes
Replaced the private
disabled_members in TracerConfig, MeterConfig and LoggerConfig withenabled_to avoid double-negative configuration patterns, aligning with OpenTelemetry Specification 4823.The public configuration APIs Enabled(), Disabled(), and IsEnabled() remain fully backwards-compatible, while the class constructors were updated to default
enabled=true.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes