Skip to content

[BUILD] Fix benchmark genrule capturing stderr into JSON output #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomsonTan merged 3 commits into from
Mar 12, 2026
Merged

[BUILD] Fix benchmark genrule capturing stderr into JSON output #3925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d2e16
[BUILD] Fix benchmark genrule capturing stderr into JSON output
ThomsonTan Mar 11, 2026
1594953
add changelog
ThomsonTan Mar 11, 2026
61e62c1
Merge branch 'main' into fix_benchmark_warning
ThomsonTan Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Increment the:

## [Unreleased]

* [BUILD] Fix benchmark genrule capturing stderr into JSON output
[#3925](https://github.com/open-telemetry/opentelemetry-cpp/pull/3925)

* [TEST] Add multi-threaded metrics benchmarks for shared vs per-thread counter
[#3865](https://github.com/open-telemetry/opentelemetry-cpp/pull/3865)

Expand Down
2 changes: 1 addition & 1 deletion bazel/otel_cc_benchmark.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def otel_cc_benchmark(name, srcs, deps, tags = [""]):
tools = [":" + name],
tags = tags + ["benchmark_result", "manual"],
testonly = True,
cmd = "$(location :" + name + (") --benchmark_format=json --benchmark_color=false --benchmark_min_time=.1s &> $@"),
cmd = "$(location :" + name + (") --benchmark_format=json --benchmark_color=false --benchmark_min_time=.1s > $@ 2>/dev/null"),
)

# This is run as part of "bazel test ..." to smoke-test benchmarks. It's
Expand Down
Loading