[BUILD] Fix benchmark genrule capturing stderr into JSON output#3925
Merged
ThomsonTan merged 3 commits intoopen-telemetry:mainfrom Mar 12, 2026
Merged
[BUILD] Fix benchmark genrule capturing stderr into JSON output#3925ThomsonTan merged 3 commits intoopen-telemetry:mainfrom
ThomsonTan merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3925 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 226 226
Lines 7223 7223
=======================================
Hits 6505 6505
Misses 718 718 🚀 New features to boost your workflow:
|
marcalff
approved these changes
Mar 12, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3926
Changes
The otel_cc_benchmark genrule used
&>to redirect both stdout andstderr into the _result.json file. SDK warnings (e.g.,
WarnOnDuplicateInstrument from measurements_benchmark) written to stderr
corrupt the JSON, causing gojq to fail with "invalid json" in CI.
Change
&> $@to> $@ 2>/dev/nullso only stdout (benchmark JSON) iscaptured; stderr diagnostics are discarded.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes