Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update INSTALL.md #2592

Merged
merged 7 commits into from
Apr 18, 2024
Merged

[DOC] Update INSTALL.md #2592

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2290cfc
Update INSTALL.md
chenhong805 Mar 16, 2024
a234a13
Update INSTALL.md
chenhong805 Mar 21, 2024
e0c6644
Merge branch 'main' into patch-1
chenhong805 Mar 21, 2024
60a8614
Merge branch 'main' into patch-1
ThomsonTan Apr 17, 2024
74a3f1e
Update INSTALL.md
marcalff Apr 18, 2024
5563a7c
Update INSTALL.md
marcalff Apr 18, 2024
24af331
Merge branch 'main' into patch-1
marcalff Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ You can link OpenTelemetry C++ SDK with libraries provided in
- `-DWITH_OTLP_GRPC=ON` : To enable building OTLP GRPC exporter.
- `-DWITH_OTLP_HTTP=ON` : To enable building OTLP HTTP exporter.
- `-DWITH_PROMETHEUS=ON` : To enable building prometheus exporter.
- [`-DOPENTELEMETRY_INSTALL=ON`](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/CMakeLists.txt): To install `libopentelemetry_common.so` needed for external code linking that rely on `ld`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CMake option is not just to install libopentelemetry_common.so, but to install all the built otel-cpp libraries

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think link to the source code is not needed here.

Copy link
Contributor Author

@chenhong805 chenhong805 Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, updated.
Removed code link, and updated description.


3. Once the build configuration is created, build the CMake targets - this
includes building SDKs and unittests for API and SDK. Note that since API is
Expand Down
Loading