[DOC] Update INSTALL.md #2592
Merged
[DOC] Update INSTALL.md #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note for build option `-DOPENTELEMETRY_INSTALL`.
lalitb
reviewed
Mar 20, 2024
INSTALL.md
Outdated
| @@ -85,6 +85,7 @@ You can link OpenTelemetry C++ SDK with libraries provided in | |||
| - `-DWITH_OTLP_GRPC=ON` : To enable building OTLP GRPC exporter. | |||
| - `-DWITH_OTLP_HTTP=ON` : To enable building OTLP HTTP exporter. | |||
| - `-DWITH_PROMETHEUS=ON` : To enable building prometheus exporter. | |||
| - [`-DOPENTELEMETRY_INSTALL=ON`](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/CMakeLists.txt): To install `libopentelemetry_common.so` needed for external code linking that rely on `ld`. | |||
There was a problem hiding this comment.
This CMake option is not just to install libopentelemetry_common.so, but to install all the built otel-cpp libraries
There was a problem hiding this comment.
I think link to the source code is not needed here.
There was a problem hiding this comment.
Thank you, updated.
Removed code link, and updated description.
|
@chenhong805 any update on CLA? |
|
closing as there was no reponse on CLA. Please feel free to repon once the issue with CLA is resolved. |
|
Done, should resolved now. |
lalitb
reviewed
Apr 17, 2024
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
marcalff
reviewed
Apr 18, 2024
marcalff
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note for build option
-DOPENTELEMETRY_INSTALL.Fixes # (issue):
#2573
Changes
Added documentation for build arg
-DOPENTELEMETRY_INSTALL.