-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2371
Merged
marcalff
merged 4 commits into
open-telemetry:main
from
marcalff:fix_get_tracer_abiv2_2032
Oct 19, 2023
Merged
[API] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2371
marcalff
merged 4 commits into
open-telemetry:main
from
marcalff:fix_get_tracer_abiv2_2032
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2371 +/- ##
==========================================
+ Coverage 87.43% 87.43% +0.01%
==========================================
Files 199 199
Lines 6028 6030 +2
==========================================
+ Hits 5270 5272 +2
Misses 758 758
|
lalitb
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. Thanks.
5 tasks
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Oct 31, 2023
## Changes Update spec-compliance-matrix.md for C++: * `Get a Tracer with scope attributes` implemented by: * open-telemetry/opentelemetry-cpp#2371 * `Links can be recorded after span creation` implemented by: * open-telemetry/opentelemetry-cpp#2380 * `get_meter accepts attributes` implemented by: * open-telemetry/opentelemetry-cpp#2224
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
## Changes Update spec-compliance-matrix.md for C++: * `Get a Tracer with scope attributes` implemented by: * open-telemetry/opentelemetry-cpp#2371 * `Links can be recorded after span creation` implemented by: * open-telemetry/opentelemetry-cpp#2380 * `get_meter accepts attributes` implemented by: * open-telemetry/opentelemetry-cpp#2224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2032
Changes
Please provide a brief description of the changes here.
API:
GetTracer()
api with 4 parameters, only available inABI VERSION 2
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes