Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trace API/SDK] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2032

Closed
lalitb opened this issue Mar 8, 2023 · 1 comment · Fixed by #2371
Closed

[Trace API/SDK] Add InstrumentationScope attributes in TracerProvider::GetTracer() #2032

lalitb opened this issue Mar 8, 2023 · 1 comment · Fixed by #2371
Assignees
@marcalff
Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change do-not-stale

Comments

@lalitb
Copy link
Member

lalitb commented Mar 8, 2023 •
edited
Loading

As mentioned in the specs, it should be possible to optionally pass the InstrumentationScope attributes while creating/fetching a Tracer through TracerProvider.

Get a Tracer

This API MUST accept the following parameters:
 * name (required)
 * version (optional)
 * [since 1.4.0] schema_url (optional)
 * since 1.13.0] attributes (optional)

With #2004, the InstrumentationScope class already support storing the attributes.

The relevant span exporters - OTLP, InMemory, and OStream should be modified to support sending/dumping these attributes.

Also this would be an API/ABI breaking change (modifying/overloading the virtual method in the API), so need to be planned accordingly.
@lalitb lalitb added the breaking change API or ABI breaking change label Mar 8, 2023
@lalitb lalitb mentioned this issue Mar 8, 2023
Closed
@github-actions
Copy link

github-actions bot commented May 8, 2023

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label May 8, 2023
@lalitb lalitb added do-not-stale and removed Stale labels May 8, 2023
@marcalff marcalff self-assigned this Sep 26, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 16, 2023
@marcalff
Fixes open-telemetry#2032
958d3a1
@marcalff marcalff mentioned this issue Oct 16, 2023
Merged
3 tasks
@marcalff marcalff added the abi:version_2 Fix is available WITH_ABI_VERSION_2 label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change do-not-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] Add InstrumentationScope attributes in TracerProvider::GetTracer() marcalff/opentelemetry-cpp
2 participants
@lalitb @marcalff