-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Add benchmark for base2 exponential histogram indexer #2181
[SDK] Add benchmark for base2 exponential histogram indexer #2181
Conversation
``` Run on (16 X 2899.97 MHz CPU s) CPU Caches: L1 Data 48 KiB (x8) L1 Instruction 32 KiB (x8) L2 Unified 1280 KiB (x8) L3 Unified 55296 KiB (x1) Load Average: 1.00, 0.33, 0.15 ------------------------------------------------------------- Benchmark Time CPU Iterations ------------------------------------------------------------- BM_NewIndexer 5.73 ns 5.74 ns 121518000 BM_ComputeIndex/-1 4.09 ns 4.09 ns 171316000 BM_ComputeIndex/0 4.08 ns 4.08 ns 171349000 BM_ComputeIndex/1 8.62 ns 8.63 ns 81330000 BM_ComputeIndex/20 8.60 ns 8.61 ns 81323000 ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank :)
Updates #1391
Changes
Add benchmark to measure performance of the indexer.
Results from a dev instance:
Negative scale has better performance due to using a custom more optimized path.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes