Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Add support for Exponential Histogram Aggregation #1391

Open
lalitb opened this issue May 13, 2022 · 10 comments
Open

[Metrics SDK] Add support for Exponential Histogram Aggregation #1391

lalitb opened this issue May 13, 2022 · 10 comments
Labels
do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics priority:p2 Issues that are not blocking

Comments

@lalitb
Copy link
Member

lalitb commented May 13, 2022

Currently, metrics SDK implementation support following aggregation:

enum class AggregationType
{
kDrop,
kHistogram,
kLastValue,
kSum,
kDefault
};

The default Histogram aggregation is implemented as described in the data model: https://github.com/open-telemetry/opentelemetry-specification/blob/90e5022a846a65600b7ad7e8d262678a83f76191/specification/metrics/datamodel.md#histogram

The data model also adds (experimental) support for Exponential histogram aggregation - https://github.com/open-telemetry/opentelemetry-specification/blob/90e5022a846a65600b7ad7e8d262678a83f76191/specification/metrics/datamodel.md#exponentialhistogram

This support needs to be implemented in the SDK.

@lalitb lalitb added this to the Metrics SDK - Beta Release milestone May 13, 2022
@lalitb lalitb changed the title [Metrics SDK] Add support for Exponential Histogram [Metrics SDK] Add support for Exponential Histogram Aggregation May 13, 2022
@lalitb lalitb added metrics good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers labels Jun 15, 2022
@lalitb
Copy link
Member Author

lalitb commented Jul 19, 2022

Moving it out of RC, as the current specs is still not stable, and the complexities involved in implementing this.

@lalitb lalitb removed this from the Metrics SDK - Release Candidate milestone Jul 19, 2022
@lalitb lalitb added this to the Metrics v1.0.0 (GA) milestone Aug 15, 2022
@lalitb lalitb self-assigned this Aug 24, 2022
@lalitb lalitb added the priority:p2 Issues that are not blocking label Aug 24, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 7, 2022
@lalitb lalitb added do-not-stale and removed Stale labels Dec 7, 2022
@euroelessar
Copy link
Contributor

@lalitb Are you open to accept changes to implement exponential histogram, given that it's now a stable feature?
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#exponentialhistogram

@lalitb
Copy link
Member Author

lalitb commented May 25, 2023

@euroelessar Yes, the contributions are welcome. Thanks for volunteering. Let me know if you want me to assign it to you ?

@euroelessar
Copy link
Contributor

@lalitb Yeah. I don't have a lot of throughput in the next month or so, but should be able to slowly produce some changes.
I have started with an implementation of an underlying adapting circular buffer (as suggested by the spec).

@lalitb
Copy link
Member Author

lalitb commented Jul 14, 2023

@euroelessar - do you plan to incorporate the remaining changes for this feature? It's not urgent, but but just in case someone want to pick up the further changes :)

@euroelessar
Copy link
Contributor

@lalitb yep! I need to update tests, implementation itself is overall ready, should be able to send it within a week or so

@lalitb
Copy link
Member Author

lalitb commented Sep 20, 2023

@euroelessar Let us know if you need any help on getting this ready? Alternatively, if someone else could take it from here, since you've already set up the foundational data structures. :)

@ThomsonTan
Copy link
Contributor

@euroelessar is there any update on this?

@luan
Copy link

luan commented Oct 27, 2023

This would be super cool if finished, @euroelessar are you still working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-stale good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics priority:p2 Issues that are not blocking
Projects
None yet
Development

No branches or pull requests

5 participants